On Tue Oct 24, 2023 at 08:19:45PM +0200, Rafael Sadowski wrote: > On Mon Oct 23, 2023 at 08:58:09PM +0200, Theo Buehler wrote: > > On Fri, Oct 20, 2023 at 05:46:33PM +0200, Rafael Sadowski wrote: > > > Hi ports, Hi bulk builders, > > > > > > I would like to disable building tests in KDE frameworks applications. > > > In a short test in devel/kf, this saves 25% build time. > > > > > > If someone wants to run the tests, they can simply set the flag to Yes. > > > > > > I hope that the bulk builds will be significantly faster and we do not > > > build that many do not need. > > > > > > What is your opinion about it? > > > > It is hard to judge how much is saved by it. My bulk had a few failures > > which in turn will have knocked out a few more ports, so the timing > > isn't going to tell us anything. > > > > It's not clear to me if all these failures are actually related ot this > > particular diff or consequences fo other qt-related changes recently. > > > > akonadi-mime > > > > Error: > > /tmp/pobj/akonadi-mime-23.08.0/fake-amd64/usr/local/bin/akonadi_benchmarker > > does not exist pkg_create: can't continue > > > > kimap > > > > Error: > > /tmp/pobj/kimap-23.08.0/fake-amd64/usr/local/include/KPim5/KIMAPTest/kimaptest/fakeserver.h > > does not exist > > Error: > > /tmp/pobj/kimap-23.08.0/fake-amd64/usr/local/include/KPim5/KIMAPTest/kimaptest/mockjob.h > > does not exist > > Error: > > /tmp/pobj/kimap-23.08.0/fake-amd64/usr/local/lib/libkimaptest.a does not > > exist > > > > kparts > > > > Error: > > /tmp/pobj/kparts-5.110.0/fake-amd64/usr/local/lib/qt5/plugins/spellcheckplugin.so > > does not exist > > > > libkipi: > > > > Error: > > /tmp/pobj/libkipi-23.08.0/fake-amd64/usr/local/lib/qt5/plugins/kipiplugin_kxmlhelloworld.so > > does not exist > > Error: > > /tmp/pobj/libkipi-23.08.0/fake-amd64/usr/local/share/kservices5/kipiplugin_kxmlhelloworld.desktop > > does not exist > > Error: > > /tmp/pobj/libkipi-23.08.0/fake-amd64/usr/local/share/kxmlgui5/kipi/kipiplugin_kxmlhelloworldui.rc > > does not exist > > > > libqaccessibilityclient > > > > Error: > > /tmp/pobj/libqaccessibilityclient-0.4.1/fake-amd64/usr/local/bin/accessibleapps > > does not exist > > Error: > > /tmp/pobj/libqaccessibilityclient-0.4.1/fake-amd64/usr/local/bin/dumper > > does not exist > > pkg_create: can't continue > > Thanks Theo for the report I had found a few of these as well. I am currently > building all devel/kf5 ports but this helps a lot. > > The errors are the result of the following wrong patterns: > > if(BUILD_TESTING) > add_subdirectory(tests) > add_subdirectory(examples) > endif() > > "examples" or other tools like akonadi_benchmarker are in the BUILD_TESTING > condition. > > I will soon come up with a new diff. >
I still haven't built all but I'm almost sure I've found most of the dependencies. I would be very grateful for a new bulk build result. diff --git a/devel/kf5/kf5.port.mk b/devel/kf5/kf5.port.mk index 0a0894ba8e9..cba68f81091 100644 --- a/devel/kf5/kf5.port.mk +++ b/devel/kf5/kf5.port.mk @@ -1,5 +1,7 @@ MODKF5_VERSION = 5.110.0 +MODKF5_BUILD_TESTING ?= No + .if empty(GH_ACCOUNT) EXTRACT_SUFX ?= .tar.xz .endif @@ -30,6 +32,11 @@ CONFIGURE_ARGS += \ # The module needs more fixes. Also, it's not clear how to deal # with multiple Python dependencies. CONFIGURE_ARGS += -DCMAKE_DISABLE_FIND_PACKAGE_PythonModuleGeneration=ON + +.if defined(MODKF5_BUILD_TESTING) && ${MODKF5_BUILD_TESTING:L} == "no" +CONFIGURE_ARGS += -DBUILD_TESTING=OFF +.endif + .endif # make sure cmake module preceeds qt5, unless we really want qmake diff --git a/devel/kf5/kparts/Makefile b/devel/kf5/kparts/Makefile index 618dc7bfaf3..d58d77188c8 100644 --- a/devel/kf5/kparts/Makefile +++ b/devel/kf5/kparts/Makefile @@ -31,4 +31,6 @@ PORTHOME = ${WRKDIR} DEBUG_PACKAGES = ${BUILD_PACKAGES} +MODKF5_BUILD_TESTING = Yes + .include <bsd.port.mk> diff --git a/x11/kde-applications/akonadi-mime/Makefile b/x11/kde-applications/akonadi-mime/Makefile index ae1818c16d9..54b26afa64a 100644 --- a/x11/kde-applications/akonadi-mime/Makefile +++ b/x11/kde-applications/akonadi-mime/Makefile @@ -35,4 +35,6 @@ LIB_DEPENDS = devel/kf5/kauth \ TEST_IS_INTERACTIVE = X11 +MODKF5_BUILD_TESTING = Yes + .include <bsd.port.mk> diff --git a/x11/kde-applications/incidenceeditor/Makefile b/x11/kde-applications/incidenceeditor/Makefile index d2021e8fc27..7f8c8a7a0c7 100644 --- a/x11/kde-applications/incidenceeditor/Makefile +++ b/x11/kde-applications/incidenceeditor/Makefile @@ -51,7 +51,7 @@ LIB_DEPENDS = graphics/kdiagram \ x11/kde-applications/libkdepim \ x11/kde-applications/eventviews - +MODKF5_BUILD_TESTING = Yes TEST_IS_INTERACTIVE = X11 .include <bsd.port.mk> diff --git a/x11/kde-applications/kimap/Makefile b/x11/kde-applications/kimap/Makefile index c9927e53478..6570f9aea62 100644 --- a/x11/kde-applications/kimap/Makefile +++ b/x11/kde-applications/kimap/Makefile @@ -18,4 +18,6 @@ LIB_DEPENDS = devel/kf5/kconfig \ security/cyrus-sasl2 \ x11/kde-applications/kmime +MODKF5_BUILD_TESTING = Yes + .include <bsd.port.mk> diff --git a/x11/libqaccessibilityclient/Makefile b/x11/libqaccessibilityclient/Makefile index 8635c8fcc59..31b2b2c40f1 100644 --- a/x11/libqaccessibilityclient/Makefile +++ b/x11/libqaccessibilityclient/Makefile @@ -20,6 +20,7 @@ EXTRACT_SUFX = .tar.xz MODULES = devel/kf5 +MODKF5_BUILD_TESTING = Yes TEST_IS_INTERACTIVE = X11 .include <bsd.port.mk>