On Mon, Nov 27, 2023 at 09:29:02AM +0000, Klemens Nanni wrote:
> Just pass it from the ports Makefile, no patch needed:
> 
> FAKE_FLAGS =  BINDIR=/usr/local/sbin

Portcheck does not like this:

hardcoded paths detected in Makefile, consider using SUBST_VARS and TRUEPREFIX/L
OCALBASE/LOCALSTATEDIR/VARBASE

> > +daemon="${TRUEPREFIX}/sbin/pfresolved"
> 
> Works, but should match what's used for BINDIR:
> 
> daemon="/usr/local/sbin/pfresolved"

I dropped the LOCALBASE patch, but keep TRUEPREFIX in Makefile and
rc script.

Now everything is consistent.  Thanks for feedback.

Reply via email to