On Sun, Dec 17, 2023 at 09:01:11AM +0100, Sebastien Marie wrote:
> Hi,
>
> The following patch add MODCARGO_WANTLIB to WANTLIB.
>
> It is required as python3.10/site-packages/bcrypt/_bcrypt.abi3.so file
> reference libc++abi and libc.
>
> 0x0000000000000001 (NEEDED) Shared library: [libc++abi.so.6.0]
> 0x0000000000000001 (NEEDED) Shared library: [libc.so.98.0]
>
> Without it, py3-bcrypt isn't updated when libc is bumped.
>
> Comments or OK ?
make port-lib-depends-check reports
Extra: pthread.27 python3.10.0
That seems an improvement over the current situation. Surely it is also
preferable to use an existing mechanism rather than handrolling the logic
here.
ok tb
> --
> Sebastien Marie
>
> diff /home/semarie/repos/openbsd/ports
> commit - 02bae0e33157daec047bd3f8064ef4dc3d7f19d9
> path + /home/semarie/repos/openbsd/ports
> blob - a75fa6b9dd49d531ab6f9ce09f3b992a5c0600ef
> file + security/py-bcrypt/Makefile
> --- security/py-bcrypt/Makefile
> +++ security/py-bcrypt/Makefile
> @@ -4,6 +4,7 @@ MODPY_EGG_VERSION= 4.1.1
> DISTNAME= bcrypt-${MODPY_EGG_VERSION}
> DISTFILES= bcrypt-${MODPY_EGG_VERSION}${EXTRACT_SUFX}
> PKGNAME= py-${DISTNAME}
> +REVISION= 0
>
> .include "crates.inc"
>
> @@ -12,7 +13,7 @@ CATEGORIES= security
> # Apache License 2.0
> PERMIT_PACKAGE= Yes
>
> -WANTLIB += pthread ${MODPY_WANTLIB}
> +WANTLIB += pthread ${MODPY_WANTLIB} ${MODCARGO_WANTLIB}
>
> COMPILER= base-clang ports-gcc
> COMPILER_LANGS= c
>
