Hi Daniel,

I don't mind the new pre-commit RDEP, though it's not actually a
dependency: pre-commit runs fine without py-nodeenv.

I'd suggest is to check if it's possible to avoid adding pre-commit
as BDEP (along with py-nodeenv).

pre-commit is a test-before-commit tool and I don't see why it becomes
build dependency. Possibly this can be fixed in the build environment.

On 02/15, Daniel Dickman wrote:
> Here's jupyter_server, a new port in the jupyter stack needed for 
> jupyterlab and a few other things.
> 
> The attachment contains a few things:
> - py-nodeenv, a new port needed by pre-commit (jupyter_server fails at 
>   build time without pre-commit having all the ports it needs)
> - a replacement Makefile for pre-commit adding the new RDEP and bumping
>   the port.
> - 2 new TDEPs for jupyter_server
> - The new jupyter_server port itself.
> 
> Note that jupyter_server cannot go to the 2.x series until 
> jupyter-notebook supports the newer version. I added a comment about that 
> in the Makefile.
> 
> ok on importing all these new ports?

-- 
With best regards,
Pavel Korovin

Reply via email to