Hello,
On 2024/03/06 10:19:39 -0500, "Jag Talon" <jag@aangat.lahat.computer> wrote:
> Notes:
> ======
>
> * Aside from bumping the version number, I also added a dependency to
> xdg-utils
> to the Makefile. Apparently it's used within the app to open external links. I
> misunderstood it as only applicable to the web version of Decker which we
> don't
> build. Now Decker is able to open external links.
>
> * I also added a new patch called patch-c_dom_h which includes sys/wait.h in
> the
> c/dom.h file. This allows the build to continue.
I've committed the update with devel/xdg-utils moved as RUN_DEPENDS.
As sthen explained, LIB_DEPENDS is only for ports that provides shared
libraries that this port links to. Instead, devel/xdg-utils only
provides a command that decker needs at runtime, so it has to be a
RUN_DEPENDS.
/usr/ports/infrastructure/bin/portcheck will caught these mistakes, it's
handy to run it after building the port to catch small issues like this
one. (tip: it's handy to add /usr/ports/infrastructe/bin to $PATH)
Also, while with CVS you can't (easily) add a directory unless you have
write access, you can still `cvs add' new files. This is better than
attaching new files because it's easier to apply them.
`cvs -q -n up -d' will tell you the state of the directory, with ?
entries being files unknown to CVS, R files marked as removed with
`cvs rm', A files added, M files modified, etc.
I'm attaching the diff that I've actually committed.
Thanks!
Index: Makefile
===================================================================
RCS file: /home/cvs/ports/graphics/decker/Makefile,v
diff -u -p -r1.2 Makefile
--- Makefile 18 Feb 2024 21:55:41 -0000 1.2
+++ Makefile 6 Mar 2024 16:02:43 -0000
@@ -1,6 +1,6 @@
COMMENT = multimedia platform inspired by HyperCard
-DIST_TUPLE = github JohnEarnest Decker v1.39 .
+DIST_TUPLE = github JohnEarnest Decker v1.40 .
PKGNAME = ${DISTNAME:L}
CATEGORIES = graphics
@@ -21,6 +21,8 @@ BUILD_DEPENDS = editors/vim \
LIB_DEPENDS = devel/sdl2 \
devel/sdl2-image
+
+RUN_DEPENDS = devel/xdg-utils
ALL_TARGET = decker lilt docs
Index: distinfo
===================================================================
RCS file: /home/cvs/ports/graphics/decker/distinfo,v
diff -u -p -r1.2 distinfo
--- distinfo 18 Feb 2024 21:55:41 -0000 1.2
+++ distinfo 6 Mar 2024 15:58:27 -0000
@@ -1,2 +1,2 @@
-SHA256 (JohnEarnest-Decker-v1.39.tar.gz) =
PTLwp775tqWUAw5/DhAtTcKtOwOvRvcAEmXSDuk4384=
-SIZE (JohnEarnest-Decker-v1.39.tar.gz) = 1343234
+SHA256 (JohnEarnest-Decker-v1.40.tar.gz) =
VnVUKMFYJ6fK+7faWc+DII+p9bpiH4itHCs4aD1kzug=
+SIZE (JohnEarnest-Decker-v1.40.tar.gz) = 1348788
Index: patches/patch-Makefile
===================================================================
RCS file: /home/cvs/ports/graphics/decker/patches/patch-Makefile,v
diff -u -p -r1.1.1.1 patch-Makefile
--- patches/patch-Makefile 18 Feb 2024 11:03:40 -0000 1.1.1.1
+++ patches/patch-Makefile 6 Mar 2024 15:58:27 -0000
@@ -13,8 +13,8 @@ Index: Makefile
# -Wno-misleading-indentation silences warnings which are entirely
spurious.
FLAGS:=$(FLAGS) -Wno-misleading-indentation -Wno-unknown-warning-option
FLAGS:=$(FLAGS) -lm
-@@ -43,16 +43,16 @@ ifneq ("$(EXTRA_FLAGS)","")
- endif
+@@ -46,16 +46,16 @@ endif
+ # FLAGS:=$(FLAGS) -DDANGER_ZONE
resources:
- @chmod +x ./scripts/resources.sh
@@ -36,7 +36,7 @@ Index: Makefile
clean:
@rm -rf ./c/build/
-@@ -60,19 +60,19 @@ clean:
+@@ -63,19 +63,19 @@ clean:
@rm -f docs/*.html
install:
Index: patches/patch-c_dom_h
===================================================================
RCS file: patches/patch-c_dom_h
diff -N patches/patch-c_dom_h
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-c_dom_h 6 Mar 2024 15:59:16 -0000
@@ -0,0 +1,9 @@
+Index: c/dom.h
+--- c/dom.h.orig
++++ c/dom.h
+@@ -1,4 +1,4 @@
+-
++#include <sys/wait.h>
+ #include "resources.h"
+
+ // Decker document object model
