On 2024/03/23 16:11:04 +0100, Peter Hessler <[email protected]> wrote:
> this error is worthless and a waste of time, stop generating it:
> /usr/ports/www/yt-dlp/pkg/PLIST changed but
> /usr/ports/www/yt-dlp/pkg/PLIST.orig exists
>
> OK?
oh yes please, it's annoying for no reason IMHO.
one small nit:
> --- infrastructure/bin/update-plist 14 May 2023 09:18:05 -0000 1.214
> +++ infrastructure/bin/update-plist 23 Mar 2024 15:07:59 -0000
> @@ -1392,7 +1392,6 @@ $self->write_new_files;
>
> # and now, we figure out where to move the new files
> my @towrite = ();
> -my $cantmove = 0;
>
> my $exitcode = 0;
>
> @@ -1412,22 +1411,13 @@ for my $p (@{$self->{lists}}) {
> } else {
> print "$k changed";
could add the \n here (or use `say')
> push(@towrite, $k);
> - if (-f "$k$orig") {
> - print " but $k$orig exists\n";
> - $cantmove = 1;
> - } else {
> - print "\n";
> - }
> + print "\n";
instead of printing \n here now.
> }
> } else {
> print "$k is new\n";
> push(@towrite, $k);
> }
> }
> -}
> -
> -if ($cantmove) {
> - exit(2);
> }
>
> if ($self->{state}->not) {
