On 2024/03/26 13:25, Omar Polo wrote:
> On 2024/03/01 01:34:01 +0100, Kirill A. Korinsky <kir...@korins.ky> wrote:
> > Greetings,
> >
> > Here an updated versio to 2.2.1 of this new port.
>
> just briefly tested since I don't use mpd anymore, but it's a nice
> client!
>
> a few tweaks, but then it's OK op@ to import
please replace
WRKSRC= ${WRKDIR}/nncmpp
WRKDIST= ${WRKSRC}
with just
WRKDIST= ${WRKDIR}/nncmpp
then it's ok
> - COMMENT should start with a lowercase unless it's an acronym or a
> proper noun (so MPD and X11 are fine capitalized, terminal not)
> - 2.1.1.tar.gz is a filename too generic, hence the DISTNAME/DISTFILES dance
> - regen wantlib
> - the termo sublibrary does interesting stuff in its cmake file.
> TL;DR nuke gio/glib checking, add CFLAGS
> Longer: it looks for gio and glib which are optionally used for some
> demos which are not installed. if not found however the build fails
> since it can't find iconv.
> - sort LIB_DEPENDS and remove glib2 from there as it is unused
> - regen wantlib
> - fold DESCR: the lines were too close to the 80 column for my taste
>
> attaching a diff against your makefile and an updated tarball.
>
> Thanks!
>
> --- Makefile.orig Tue Mar 26 12:00:53 2024
> +++ Makefile Tue Mar 26 12:25:47 2024
> @@ -1,11 +1,11 @@
> -COMMENT= Terminal/X11 MPD client
> +COMMENT= terminal/X11 MPD client
>
> V= 2.1.1
> V.liberty= 969a4cfc3ea1c4d7c0327907385fc64906ed5d4c
> V.termo= 2518b53e5ae4579bf84ed58fa7a62806f64e861c
>
> -PKGNAME= nncmpp-${V}
> -DISTNAME= v${V}
> +DISTNAME= nncmpp-${V}
> +DISTFILES= nncmpp-{v}${V}${EXTRACT_SUFX}
>
> CATEGORIES= audio
>
> @@ -21,18 +21,20 @@
> # ISC
> PERMIT_PACKAGE= Yes
>
> -WANTLIB= X11 Xft Xrender unistring ncursesw gio-2.0 glib-2.0
> -WANTLIB+= curl freetype fontconfig png m iconv
> +WANTLIB += X11 Xft Xrender c curl curses fontconfig freetype iconv
> +WANTLIB += m png pthread unistring
>
> MODULES= devel/cmake
>
> +# for iconv
> +CFLAGS+= -I${LOCALBASE}/include
> +
> BUILD_DEPENDS= textproc/asciidoctor \
> x11/gnome/librsvg
>
> LIB_DEPENDS = converters/libunistring \
> - devel/glib2 \
> - net/curl \
> - graphics/png
> + graphics/png \
> + net/curl
>
> RUN_DEPENDS = devel/desktop-file-utils \
> x11/gtk+4,-guic
>
