On 2024/10/05 15:44:45 +0200, Kirill A. Korinsky <[email protected]> wrote:
> On Sat, 05 Oct 2024 14:09:51 +0200,
> Klemens Nanni <[email protected]> wrote:
> >
> > 05.10.2024 00:24, Kirill A. Korinsky пишет:
> > > ping.
> > >
> > > I'm using it for more than a month to chat with two contacts who insist to
> > > switch to this IM.
> > >
> > > It works well on -current.
> > >
> > > To make things easy I've re-inlinded both diffs.
> >
> > Thanks, looks almost good port-wise, see inline.
> >
>
> Here addressed all review remarks.
Thank you! I'm generally ok with these patches, provided that we remove
net/utox while here. any oks to do so?
one nit:
> --- net/toxic/Makefile 6 May 2024 12:23:55 -0000 1.20
> +++ net/toxic/Makefile 5 Oct 2024 13:43:46 -0000
> @@ -14,12 +11,13 @@ WANTLIB += alut c config curses curl m o
> WANTLIB += qrencode toxcore util z ${MODPY_WANTLIB}
>
> LIB_DEPENDS = audio/freealut \
> - net/toxcore \
> + net/toxcore>=0.2.19 \
I'm not sold on this one. We're bumping toxcore major, so the package
will register the dependency on toxcore.so.4.0 and (I believe) even a
partial upgrade will pull in the new toxcore version.
but even if it didn't, I don't see why we should do this for a lib
depends. I could be convinced if it were a build or run dep. Do we
really want to start tracking the minimum requirements for packages?
