On Mon, Jun 16, 2025 at 09:36:57PM +0200, Volker Schlecht wrote:
> Hi,
>
> Fabien Romano found out that lang/node is assuming that threads support
> is enabled in OpenSSL. In our port, it isn't - which means that some
> (all?) async crypto functions of the NodeJS API are mostly broken.
>
> With the attached patch, lang/node seems happier.
>
> opinions? oks?
I'm fine with this, but it needs to be done for all three openssl copies
we have. Since everybody else will have this option enabled, it feels
like a bad idea to deviate. Unless there are objections I will take care
of this in a few days along with the required bumping of the dependent
statically linked ports.
It looks like something that was copied over from the initial port
for 1.0.1h and never revisited.
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/security/openssl/3.3/Makefile,v
> retrieving revision 1.14
> diff -u -p -r1.14 Makefile
> --- Makefile 16 Jun 2025 13:56:20 -0000 1.14
> +++ Makefile 16 Jun 2025 19:22:30 -0000
> @@ -12,13 +12,13 @@ PKGNAME= openssl-${V}
> PKGSPEC= openssl->=3.3v0,<3.4v0
> EPOCH= 0
>
> -REVISION= 0
> +REVISION= 1
>
> SHLIBVER= 27.0
> SHARED_LIBS= crypto ${SHLIBVER} \
> ssl ${SHLIBVER}
>
> -WANTLIB= c
> +WANTLIB= c pthread
>
> DEBUG_PACKAGES = ${BUILD_PACKAGES}
>
> @@ -26,7 +26,7 @@ CONFIGURE_STYLE= simple
> CONFIGURE_SCRIPT= config
> CONFIGURE_ARGS+= --prefix=${PREFIX} \
> --openssldir=/etc/ssl \
> - no-threads no-rc5 no-ssl3 \
> + no-rc5 no-ssl3 \
> no-devcryptoeng \
> shared
>
