On 2025/10/12 17:55, Chris Billington wrote:
> On Sun, 12 Oct 2025 09:34:28 +0100
> Stuart Henderson <s...@spacehopper.org> wrote:
> 
> > On 2025/10/12 16:25, Chris Billington wrote:
> > > The use of uint64_t for the base address was because the SMBIOS
> > > specification [2] defines the start address as 64-bit (p24 on the
> > > version referenced).
> > 
> > wouldn't it make more sense to use the existing u64 type used in
> > other parts of dmidecode? (obviously that's not OpenBSD's style, but
> > when patching for a port, usually better to follow upstream style).
> > 
> > > I'll get in touch with dmidecode upstream and see if any of these
> > > patches can be accepted by them, and keep the list informed.
> > 
> > thanks.
> 
> Makes sense, but just after 3.6 was released upstream have changed the
> handling of u64 as in this commit:
> 
> https://cgit.git.savannah.gnu.org/cgit/dmidecode.git/commit/?id=2fa4ab1a1d37303b81e701d7ed08ae70965ab96c

ah so it's just a typedef now. that seems simpler to deal with.

> I'm trying to figure out what that all means and see if I can apply
> patches to their head code.
> 
> -- 
> Chris Billington

fwiw here's a ports diff to build against a git-archive:

Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/dmidecode/Makefile,v
diff -u -p -r1.19 Makefile
--- Makefile    25 Apr 2024 11:53:34 -0000      1.19
+++ Makefile    12 Oct 2025 10:25:44 -0000
@@ -3,12 +3,14 @@
 ONLY_FOR_ARCHS=        amd64 i386
 
 COMMENT=       dump DMI/SMBIOS contents in human-readable format
-DISTNAME=      dmidecode-3.6
-EXTRACT_SUFX=  .tar.xz
+PKGNAME=       dmidecode-3.7pl20251004
+DISTNAME=      dmidecode-70c99ec5c133e78e6239f4c34a8c71687e18f492
+#EXTRACT_SUFX= .tar.xz
 
 CATEGORIES=    sysutils
 
-SITES=         ${SITE_SAVANNAH:=dmidecode/}
+#SITES=                ${SITE_SAVANNAH:=dmidecode/}
+SITES=         https://cgit.git.savannah.gnu.org/cgit/dmidecode.git/snapshot/
 
 HOMEPAGE=      https://www.nongnu.org/dmidecode/
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/sysutils/dmidecode/distinfo,v
diff -u -p -r1.11 distinfo
--- distinfo    25 Apr 2024 11:53:34 -0000      1.11
+++ distinfo    12 Oct 2025 10:25:44 -0000
@@ -1,2 +1,2 @@
-SHA256 (dmidecode-3.6.tar.xz) = 5Axl8+w9r+Ma2DSaTvGpcSLTj2UATtZldeGo1XXdi64=
-SIZE (dmidecode-3.6.tar.xz) = 69284
+SHA256 (dmidecode-70c99ec5c133e78e6239f4c34a8c71687e18f492.tar.gz) = 
lDPTvWqZKVWUMZBUpiu4ZZmVO9ufsoj240DSIUpdlYU=
+SIZE (dmidecode-70c99ec5c133e78e6239f4c34a8c71687e18f492.tar.gz) = 88382

Reply via email to