On 2025/11/18 12:19, Peter Haag wrote: > On 17.11.2025 17:50, Stuart Henderson wrote: > > On 2025/11/12 12:46, Peter Haag wrote: > > > On 12.11.2025 12:29, Stuart Henderson wrote: > > > > will take a look, probably in a day or two. I don't see any need to > > > > split off ft2nfdump (and at this point I think I'd merge nfprofile so > > > > it's all in one package). > > > > > > The split off ft2nfdump was intended to have a small and clean nfdump > > > package without any other dependancies. > > > > > > I would not recommend to merge nfprofile. It's legacy and will get > > > dropped anyway in future. Furthermore > > > you pull too many uneeded packages due to the rrd depedancies for the > > > majority of users, which do not > > > need nfprofile at all. > > > > flow-tools is pretty tiny as far as dependencies go. > > > > With this update libnffile pulls in rrd dependencies now anyway > > so I don't see a point in _not_ merging nfprofile? > > That's because of the way the subpackage works.
it's not, it didn't happen before 1.7.7. seems it's because of the change in 5986db66e6fd25b. previously: $ objdump -p libnffile.so.1.0 | grep NEEDED NEEDED libpthread.so.28.1 NEEDED libz.so.7.1 NEEDED liblz4.so.3.3 NEEDED libbz2.so.10.4 NEEDED libzstd.so.7.0 with that commit: $ objdump -p libnffile.so.1.0 | grep NEEDED NEEDED libpthread.so.28.1 NEEDED libz.so.7.1 NEEDED librrd.so.6.0 NEEDED libcairo.so.13.5 NEEDED libglib-2.0.so.4201.15 NEEDED libgobject-2.0.so.4200.22 NEEDED libharfbuzz.so.18.20 NEEDED libintl.so.8.1 NEEDED libm.so.10.1 NEEDED libpango-1.0.so.3801.6 NEEDED libpangocairo-1.0.so.3801.3 NEEDED libpng.so.18.2 NEEDED libxml2.so.22.1 NEEDED libiconv.so.7.1 NEEDED libfreetype.so.31.1 NEEDED libexpat.so.17.0 NEEDED libxcb.so.4.1 NEEDED libX11.so.19.0 NEEDED liblz4.so.3.3 NEEDED libbz2.so.10.4 NEEDED libzstd.so.7.0 > Maybe a flavour would be better and cleaner. flavours are a problem for ports that provide libraries. > Yes - nfprofile is used for nfsen only and nowhere else. However, in future, > there should > be a new NfSen and therefore it will be legacy anyway. Ah nice - since nfprofile is only present in the port to support www/nfsen then we'll be able to remove it later when that's ready.
