On Thu, 08 Jan 2026 20:01:50 +0100, izzy Meyer <[email protected]> wrote: > > On Thu, 08 Jan 2026 01:44:27 +0100 > Kirill A. Korinsky <[email protected]> wrote: > > > On Tue, 06 Jan 2026 22:37:16 +0100, > > izzy Meyer <[email protected]> wrote: > > > > > > [1 <text/plain; US-ASCII (7bit)>] > > > Hello ports@, > > > > > > Here are some open source reimplementations of the original two > > > fallout games. > > > > > > fallout1-ce needs a lower -O level for some likely UB in the code > > > I've not ironed out yet. But until I figure that out or upstream > > > fixes it, it should be OK to keep as-is with the lower -O value in > > > CFLAGS/CXXFLAGS and the related comment hint for user experience. > > > > > > They come with pkg-readme files to inform the end-user on how to use > > > them. > > > > > > Tested on amd64 and completed a playthrough of fallout1 with > > > fallout1-ce, still working on my playthrough of fallout2. Things > > > seem fairly stable for now. > > > > > > Could I get OKs? Or at least a look over by a more experienced > > > porter? > > > > > > Thanks, > > > > > > > Thoughts. > > > > 1) CATEGORIES = x11 games reads strange, maybe games x11? > > Good point. Are CATEGORIES usually alphabetical? >
I think that this is style question, but usually the first one is where port is. And I just assumed that both are targeted to games/ > > 2) Any reason to not add fpattern as a port which is used at build > > time? > > IIRC these ports use different releases of fpattern. > I don't see any fpattern in the port tree > > 3) I think readme should explain where to put and which files. > > It doesn't matter where the files are, you just need to be in the cwd > of the gamefile's extracted dir like the readme says. > ah > > 4) About license, I read this: > > > > > You may use or modify the software only for your own internal > > > business purposes or for non-commercial or personal use. You may > > > distribute the software or provide it to others only if you do so > > > free of charge for non-commercial purposes. > > > > I not sure that it can be distributed as precompiled package. > > > > Upstream wasn't too helpful when I asked about this either [1] > > [1] https://github.com/alexbatalov/fallout2-ce/issues/428 > Now I recall that! My point that it needs: PERMIT_DISTFILES = No PERMIT_PACKAGE = No but other may have other point of view on this. -- wbr, Kirill
