Stuart Henderson [[email protected]] wrote:
> On 2026/01/15 20:07, Chris Cappuccio wrote:
> > This is the Codex LLM agent from OpenAI.
> 
> I have some tweaks, will send out a tar later as it needs to finish
> building before I make some WANTLIB fixes for the flavour. Quoted diff
> below with commentary in-line.
> 
> What is the flavour for? I'd prefer to drop it unless it's really
> important. (if kept it needs mentioning in DESCR).
> 

I originally assumed they would require some openssl3-isms and started
to try and scaffold it in there, but when it worked with libressl I
left it in as a flavor, which was a mistake. It's going to waste build time.

> | -SITES.ratatui =            https://github.com/nornagon/ratatui/archive/
> | -DISTFILES.ratatui =        
> ratatui-${RATATUI_COMMIT}{${RATATUI_COMMIT}}${EXTRACT_SUFX}
> 
> this is exactly what DIST_TUPLE is for (I avoided it for the main
> distfile because portroach doesn't handle it)
> 

Noted

> | diff -uNp -r codex-/distinfo codex/distinfo
> | --- codex-/distinfo Fri Jan 16 00:20:39 2026
> | +++ codex/distinfo  Fri Jan 16 12:15:02 2026
> ..snip.. (changed for DIST_TUPLE filenames)
> 
> | --- codex-/patches/patch-codex-rs_Cargo_toml        Thu Jan 15 20:03:21 2026
> | +++ codex/patches/patch-codex-rs_Cargo_toml Fri Jan 16 12:12:54 2026
> | @@ -1,13 +1,14 @@
> | ---- codex-rs/Cargo.toml.orig       Thu Jan 15 11:59:24 2026
> | -+++ codex-rs/Cargo.toml    Thu Jan 15 12:00:25 2026
> | -@@ -301,8 +301,8 @@
> | +Index: codex-rs/Cargo.toml
> | +--- codex-rs/Cargo.toml.orig
> | ++++ codex-rs/Cargo.toml
> 
> use "make port-lib-depends-check" to generate these
> 

Will this automatically unpack the source archive and diff it against my 
modified tree?

> | +@@ -301,8 +301,8 @@ opt-level = 0
> |   [patch.crates-io]
> |   # Uncomment to debug local changes.
> |   # ratatui = { path = "../../ratatui" }
> |  -crossterm = { git = "https://github.com/nornagon/crossterm";, branch = 
> "nornagon/color-query" }
> |  -ratatui = { git = "https://github.com/nornagon/ratatui";, branch = 
> "nornagon-v0.29.0-patch" }
> | -+crossterm = { path = 
> "../../crossterm-87db8bfa6dc99427fd3b071681b07fc31c6ce995" }
> | -+ratatui = { path = 
> "../../ratatui-9b2ad1298408c45918ee9f8241a6f95498cdbed2" }
> | ++crossterm = { path = "../../crossterm" }
> | ++ratatui = { path = "../../ratatui" }
> 
> simpler path from DIST_TUPLE

This will make future updates easier.

Thanks,

Chris

Reply via email to