01.02.2026 13:48, Sebastian Reitenbach пишет: > Hi Klemens, > > I think I addressed all your concerns, see below. > Updated tarball attached. > > On Sat, Jan 31, 2026 at 2:49 PM Klemens Nanni <[email protected] > <mailto:[email protected]>> wrote: > > 28.01.2026 16:55, Sebastian Reitenbach пишет: > > Hi, > > > > cat pkg/DESCR: > > OpenVoxDB is a fork of Open Source PuppetDB. > > > > OpenVoxDB is the fast, scalable, and reliable data warehouse for > OpenVox. > > It caches data generated by OpenVox, and gives you advanced features at > > awesome speed with a powerful API. > > > > Similarly to OpenVox server, it will eventually replace PuppetDB. To > eventually support multiple major versions, same structure used as > databases/puppetdb. > > Makes sense. > > I don't think '@pkgpath databases/puppetdb/7' is needed. > > > removed > > > > infrastructure/db/user.list should mention openvoxdb as well. > > > see attached user.list.diff file > > > > patches/ harcodes /var while the .rc file uses LOCALSTATEDIR; > both is fine to me really, but it should be consistent. > > > I went the /var route. > > > > patches/ has files with 'env bash' shebangs and do-configure > sed-patches other files to use an absoloute path. Both work, > but I'd prefer we stick to one way of fixing/using bash. > > I chose the env bash version. > > > > Strictly speaking, I think, MAKE_FLAGS should be FAKE_FLAGS > since only do-install uses them and NO_BUILD=Yes. > > > Renamed > > > > Overall, it'd be nice if openvoxdb and openvox-server Makefiles > would match; they share a lot, but have churn wrt. V/VERSION, > spaces/no spaces before =, etc. which makes reading harder than > it should be. > > > Should be better now. > > > > > > > Same as with OpenVox server, between 8.11 and 8.12, they dropped the > Makefile with the install target. Therefore using same approach here, and > added the old Makefile to the files directory. > > I lack the details/background here, but the approach seems fine > except for > > - 'rubylibdir ?= $(shell ruby ...)': > - needs USE_GMAKE=Yes (only openvox-server sets it) > - should probably use MODRUBY_* stuff to get the binary name > or not use a shell command at all > > - you default 'confidir ?= /etc' and others, bu then also pass > them in the ports Makefile; we control both, so wouldn' it > be simpler to use SYSCONFDIR in files/Makefile right away? > > > To the TWO points above: > I don't know yet, why they removed the Makefile, I wanted to check with > upstream. > Therefore I intended to keep the way it was working with puppetdb.
Sure. > Actually, what is in the file, i.e. the 'rubylibdir ?= $(shell ruby ...)' is > not executed, > because it's overridden by the FAKE_FLAGS. therefore no USE_GMAKE anymore, > must have been an old leftover.... Right, this quickly gets confusing. I think it'd help if you added a comment to post-extract or the top of files/Makefile briefly explaining where it's from, why it's used and what was (not) changed. Then it should be easier to understand this. No need to resend a tarball for this. OK kn to import, one nit below, feel free to take it or leave it: - sysutils/ruby-openvox/8>=8.0.0,<9.0.0v0 that version spec seems redundant; the ports branch ensures it's fine > > > > > - does it really need to have all the targets we don't use? > > > removed the superfluous targets.
