Hi Stuart, I
On Thu, Feb 12, 2026 at 10:18 AM Sebastian Reitenbach < [email protected]> wrote: > Hi Stuart, > > > > On Wed, Feb 11, 2026 at 9:29 PM Stuart Henderson <[email protected]> > wrote: > >> On 2026/02/11 20:20, Sebastian Reitenbach wrote: >> > Hi, >> > >> > this updates py-tsk to latest, and while there take MAINTAINER. >> > Tidy Makefile a bit, and instead of patching setup.py and pre-configure >> dance, >> > add sleuthkit:path to BUILD_DEPS ... >> > >> > with tests downloaded from git repo, they all pass. >> > >> > comments, etc. or even OK welcome. >> > >> > cheers, >> > Sebastian >> >> If you build the old version, you'll see that with those patches it >> didn't build the bundled version of sleuthkit. >> it does build the bundled copy. >> >> With your change, it installs sleuthkit as a library dependency, >> then extracts/patches sleuthkit in WRKDIR and symlinks it into >> WRKSRC/sleuthkit/sleuthkit-$VERSION, then totally ignores that copy >> and the library dependency and goes on to build the bundled version. >> This is not optimal > > > >> Diff below is a cleaner way to build with the bundled lib (at least >> it doesn't pretend that it's using the ports one) also fixes running >> tests the normal ports way (the comment was wrong, test_data is >> there, but it misses some *.py files). >> > awesome, works great, I kept this in my version, read below. > >> I think it might be better to bring back the patch and fix things so >> that it builds against ports sleuthkit rather than the bundled one, >> but I didn't see how to do that. >> > I totally overlooked, that the directory contains a bundled version, and ln -s silently fails :/ I managed to integrate this with the version we have in the ports tree by using sleuthkit:configure instead of sleuthkit:patch. As I see it now, this builds using our version in Ports. The two should probably always be updated in-sync with each other anyways. I figured, with libtalloc it's the same, so I re-introduced the setup.py patch, and was able to build/link against installed libtalloc. I didn't manage to do the same with the sleuthkit :/ find my new version attached. cheers, Sebastian > >>
py-tsk.patch
Description: Binary data
