Yes, it's possible that a patch still applies in this case, but not 'cleanly'.
Here's the difference for moor:
Before `make update-patches`:
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: internal/reader/reader_test.go
|--- internal/reader/reader_test.go.orig
|+++ internal/reader/reader_test.go
--------------------------
Patching file internal/reader/reader_test.go using Plan A...
Hunk #1 succeeded at 21 (offset 2 lines).
After `make update-patches`:
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: internal/reader/reader_test.go
|--- internal/reader/reader_test.go.orig
|+++ internal/reader/reader_test.go
--------------------------
Patching file internal/reader/reader_test.go using Plan A...
Hunk #1 succeeded at 21.
The telltale is "(offset 2 lines)". Personally I just made it a habit
to always run `make update-patches` instead of scanning through those
lines, though.
On 3/15/26 5:34 PM, Lydia Sobot wrote:
Thanks. You missed a 'make update-patches', I did that and committed.
Thanks, I'm a bit surprised it applied cleanly on my end without it
