On 2026/05/18 21:01, Volker Schlecht wrote:
> On 5/18/26 8:52 PM, Stuart Henderson wrote:
> > On 2026/05/18 19:45, Volker Schlecht wrote:
> > > +DIST_TUPLE =     github PCRE2Project pcre2 pcre2-${V} .
> > > +
> > > -SITES =          
> > > https://github.com/PCRE2Project/pcre2/releases/download/${DISTNAME}/
> > 
> > They still make proper tarball releases, please use them
> 
> Didn't know that was preferable - fixed diff attached.

yep, less likely to change randomly because of an unrelated commit
or an infrastructure change as can happen with git-archive, and it's
the actual artefact produced by upstream (when they do that) and is
more likely to have things like autoconf scripts generated, etc.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/pcre2/Makefile,v
> retrieving revision 1.21
> diff -u -p -r1.21 Makefile
> --- Makefile  18 Dec 2024 09:40:10 -0000      1.21
> +++ Makefile  18 May 2026 18:59:13 -0000
> @@ -1,10 +1,10 @@
>  COMMENT =    perl-compatible regular expression library, version 2
>  
> -DISTNAME =   pcre2-10.44
> +DISTNAME =   pcre2-10.47
>  
> -SHARED_LIBS +=  pcre2-16                  0.6 # 13.0
> -SHARED_LIBS +=  pcre2-32                  0.6 # 13.0
> -SHARED_LIBS +=  pcre2-8                   0.7 # 13.0
> +SHARED_LIBS +=  pcre2-16                  0.7 # 13.0
> +SHARED_LIBS +=  pcre2-32                  0.7 # 13.0
> +SHARED_LIBS +=  pcre2-8                   0.8 # 13.0
>  SHARED_LIBS +=  pcre2-posix               1.0 # 3.5

the upstream versions changed (check them in shared_libs.log after
building):

SHARED_LIBS +=  pcre2-16             0.7      # 15.0
SHARED_LIBS +=  pcre2-32             0.7      # 15.0
SHARED_LIBS +=  pcre2-8              0.8      # 15.0
SHARED_LIBS +=  pcre2-posix          1.0      # 3.7

> @@ -26,7 +26,9 @@ CONFIGURE_ARGS =    --enable-pcre2-16 \
>                       --enable-pcre2-32 \
>                       --enable-pcre2grep-libz \
>                       --enable-pcre2grep-libbz2 \
> -                     --enable-pcre2test-libreadline
> +                     --enable-pcre2test-libreadline \
> +                     --disable-symvers

I think that's a reasonable decision for now (the old version didn't
have versioned symbols, this is a new on-by-default option).

With --disable-symvers I'd be reasonably happy to just commit and not
worry about a load of extra testing. If we want to use the upstream
default and enable symbol versioning I think that probably would need
a bulk (and afaik major bumps).

I'm happy with that version of the diff (i.e. ok). Not sure whether
namn is around or not.

Reply via email to