Hi Volker, thanks for the feedback!
Am Di, 26. Mai 2026, um 20:44, schrieb Volker Schlecht:
> * My instinct would be to name the SUBDIRs 19 and 20 instead of 0.19 and 0.20
Looking at existing multi-version ports in the tree, the dotted
convention seems to be consistent: lang/lua/{5.1,5.2,5.3,5.4},
lang/python/{2.7,3}, lang/ruby/{3.3,3.4,4.0}. I couldn't find a
precedent for stripping the dot, so I went with what's already
established.
Having said this, there does not seem to be any port with a version
<1.0; so I'll still happily change this ...
> * I think that EPOCH=0 needs to be added to Makefile.inc
Done.
> * ... which turns the PKGSPEC for both into >=0.19v0,<0.20v0 /
> >=0.20v0,<0.21v0
Done.
> * I think that you need to add a "@pkgpath wayland/wlroots" to the PLISTs
Added this to 0.19/pkg/PLIST. Following lang/lua/5.1/pkg/PLIST, only the
version that previously lived at the un-versioned path declares the old
pkgpath. Right?
> * I think that the @conflict markers should be aligned with the PKGSPECs
Done.
> * MODWLROOTS_LIB_DEPENDS needs tweaking
> (assuming that the SUBDIRs are 19/ and 20/):
Kept for now, see point above.
Appreciate the second pair of eyes and keen to hear if anyone more
familiar with the multi-version idiom disagrees with any of the above.
New TGZ attached, diff also updated at:
https://github.com/roblillack/openbsd-ports/pull/2/changes
Best,
--rob.
--
http://roblillack.net/
pgp key id: 0xE7FFDF77
wlroots-0.20.tgz
Description: Binary data
