Hi Leah,
I had a look at your port and I did some testing. A couple of comments
and questions:
- Question to other developers: I think it would make sense to have
SO_VERSION start at 0.0 instead of 163.0. Do you agree?
- When diffing LibreWolf's Makefile with Firefox' Makefile, I see some
differences that are mostly whitespace or the addition of quotes (").
I can see why you'd do that, but in the interest of keeping the diff
with Firefox as small as possible, if I were you I'd just follow what
the Firefox port does. If you would want to fix those, my approach would
be to first change those in the Firefox port and then you could copy
them to LibreWolf again. But in the end, it's up to you :)
- And of course the port would need some catching up to the changes in
the last few days, like landry@'s LLVM 22 fixes.
- patch-lw_policies_json: the last few lines look like the patch file
originates from git. Perhaps you can do "make update-patches" to
make sure it doesn't introduce a useless diff later.
With the points above figured out and addressed, I think it looks
pretty good! Let me know what you think.
Caspar
On Sun, May 24, 2026 at 05:02:58PM +0100, Leah Rowe wrote:
> Hello everyone,
>
> Please also refer to my previous thread:
>
> https://marc.info/?t=177652919000001&r=1&w=2
> <https://marc.info/?t=177652919000001&r=1&w=2>
>
> Given the number of design changes since that submission, I am starting
> a new thread for this updated LibreWolf port.
>
> The attached port files integrate LibreWolf 151.0.1-2, corresponding
> to Firefox 151.0.1. In OpenBSD's native package versioning scheme, this then
> becomes:
>
> librewolf-151.0.1pl2
>
> The port is also available from this branch on my Git repository, where I
> host and maintain my copy of the port:
>
> https://codeberg.org/vimuser/librewolf-openbsd-port/src/branch/submit6
> <https://codeberg.org/vimuser/librewolf-openbsd-port/src/branch/submit6>
>
> LibreWolf is a Firefox-derived browser focused on privacy, security,
> and software freedom. It removes telemetry, disables DRM by default,
> ships uBlock Origin by default, and carries a number of privacy-oriented
> default settings and upstream source-level changes.
>
> More information about LibreWolf’s features is available here:
>
> https://librewolf.net/docs/features/ <https://librewolf.net/docs/features/>
>
> I am submitting this as a separate browser port, not as a replacement
> for www/mozilla-firefox. My intention is to keep it closely in sync with
> the Firefox port and with LibreWolf upstream releases. LibreWolf regularly
> syncs with Firefox releases, usually releasing a new version on the same day
> as Firefox, corresponding to each given Firefox release. Users who are
> familiar with Firefox can use this LibreWolf port and know that it is kept
> up to date (especially with new security fixes), just as with the official
> Firefox port.
>
> The port is based heavily on www/mozilla-firefox, with the
> necessary adaptations for LibreWolf’s source tarballs. I have tried to keep
> the LibreWolf source tree as close to upstream as practical, while
> carrying only the OpenBSD-specific changes required for this port. I will be
> the official maintainer for this port, so I have set MAINTAINER accordingly.
> I'm happy to answer questions about it, moving forward, and work with the
> OpenBSD ports team.
>
> The main implementation difference from www/mozilla-firefox is
> that LibreWolf uses a mozconfig file for mach/build-system configuration. As
> a result, OpenBSD CONFIGURE_ARGS have no effect on the LibreWolf build
> system. To handle this, the port carries a patched OpenBSD-specific
> mozconfig:
>
> files/mozconfig-openbsd
>
> The Makefile then adjusts this during pre-configure, based on the same kind
> of build-time options and conditions handled in the Firefox
> port. CONFIGURE_ENV and related environment settings are still used
> where appropriate. During pre-configure, this patched mozconfig then
> replaces the original upstream one, thus replicating the effect of using
> CONFIGURE_ARGS in www/mozilla-firefox.
>
> I considered removing or bypassing LibreWolf’s mozconfig so that the
> port would more closely mirror OpenBSD's CONFIGURE_ARGS handling on
> www/mozilla-firefox. However, that would require far more invasive patching
> of the LibreWolf source tree and would considerably increase the maintenance
> burden. The current approach has worked across multiple LibreWolf releases
> and keeps the upstream tarball (applied to our use-case) closer to
> its original form.
>
> Notable changes relative to www/mozilla-firefox include:
>
> * Adaptation of the Firefox port to LibreWolf’s source tarballs and
> versioning scheme.
>
> * Use of LibreWolf’s release suffix as an OpenBSD patchlevel. For example,
> LibreWolf 151.0.1-2 is represented as librewolf-151.0.1pl2. These LibreWolf
> suffix changes should be treated as new upstream releases for OpenBSD
> purposes, rather than as OpenBSD REVISION bumps.
>
> * Addition of files/mozconfig-openbsd and Makefile logic to adjust it during
> pre-configure (as already articulated above).
>
> * Adaptation of pledge/unveil-related files for LibreWolf (inherited from
> www/mozilla-firefox).
>
> * Adaptation of README, DESCR, and the manpage for LibreWolf (versus
> www/mozilla-firefox).
>
> * Adaptation of OpenBSD-specific Firefox policy changes, including default
> policy changes such as DontCheckDefaultBrowser and the disabling of AI
> features where applicable.
>
> * Removal of icon files that were present in earlier submissions, since the
> required 22x22, 24x24, and 256x256 LibreWolf icons have since been merged
> upstream.
>
> * Tidying of repeated paths in the Makefile by using variables, while
> keeping line lengths below 79 columns where practical.
>
> The attached port has been tested by me as my regular OpenBSD browser,
> and other users have also reported successful use of earlier versions of
> this port. I am happy to make any changes requested during review.
>
> I also intended to make another change, whereby www/mozilla-firefox and
> www/librewolf would both use a single, newly generalised module named
> www/mozilla-browser (akin to how multiple types of mozilla project all
> derive from www/mozilla). However, Landry has informed me (in the previous
> thread) that such a change would be unwelcome, so I will keep this port
> separate from Firefox.
>
> Merge note:
>
> I included a LICENSE file to clarify that the port inherits licensing
> from the original Firefox port, and that my own modifications and additions
> are under the ISC license where applicable. I assume this file would
> probably be removed before import, since other ports do not usually carry
> such a file, but I included it here to make the licensing status of my
> changes explicit.
>
> Side note:
>
> Several changes from this OpenBSD port have also been accepted upstream
> by LibreWolf, including default use of --enable-sandbox.
>
> Comments and review are welcome.
>
> --
> Company director, Minifree Ltd
> Registered in England, No. 9361826 | VAT No. GB202190462
> Registered Office: 19 Hilton Road, Canvey Island, Essex SS8 9QA, UK
>