On Sun, May 31, 2026 at 04:18:24PM -0700, Thomas Frohwein wrote:
> On Sun, 31 May 2026 19:15:57 +0200
> Christian Weisgerber <[email protected]> wrote:
>
> > http://build-failures.rhaalovely.net/amd64/2026-05-30/
>
> [...]
>
> > games/falconseye espie@
>
> Diff below fixes the build. I'm not sure what's up with runtime - I get
> nethack in the terminal and the separate GUI window stays blank. I
> doubt that's related to the diff below though, so would still advocate
> that we fix the build.
I think it would be better to drop the casts and ifdefs.
Index: Makefile
===================================================================
RCS file: /cvs/ports/games/falconseye/Makefile,v
diff -u -p -r1.35 Makefile
--- Makefile 7 Nov 2023 14:19:29 -0000 1.35
+++ Makefile 1 Jun 2026 00:16:07 -0000
@@ -3,7 +3,7 @@ COMMENT = NetHack derivative
VERSION = 1.9.3
DISTNAME = nethack_source_331_jtp_${VERSION:S/.//g}
PKGNAME = falconseye-${VERSION}
-REVISION = 10
+REVISION = 11
CATEGORIES = games x11
EXTRACT_SUFX = .zip
Index: patches/patch-sys_unix_unixunix_c
===================================================================
RCS file: /cvs/ports/games/falconseye/patches/patch-sys_unix_unixunix_c,v
diff -u -p -r1.2 patch-sys_unix_unixunix_c
--- patches/patch-sys_unix_unixunix_c 11 Mar 2022 19:04:20 -0000 1.2
+++ patches/patch-sys_unix_unixunix_c 1 Jun 2026 00:20:02 -0000
@@ -1,12 +1,15 @@
---- sys/unix/unixunix.c.orig Sun Jun 24 18:57:24 2001
-+++ sys/unix/unixunix.c Wed Jul 4 11:23:29 2001
-@@ -42,7 +42,9 @@ gethdate(name)
- * does not exist on all systems, and moreover, that it sometimes includes
- * <sys/types.h> again, so that the compiler sees these typedefs twice.
- */
-+#ifndef HAVE_SYS_PARAM_H
- #define MAXPATHLEN 1024
-+#endif
-
- register const char *np, *path;
- char filename[MAXPATHLEN+1];
+Index: sys/unix/unixunix.c
+--- sys/unix/unixunix.c.orig
++++ sys/unix/unixunix.c
+@@ -121,11 +121,7 @@ int fd;
+ #ifndef INSURANCE
+ if(buf.st_size != sizeof(int)) return(0); /* not an xlock file */
+ #endif
+-#ifdef BSD
+- (void) time((long *)(&date));
+-#else
+ (void) time(&date);
+-#endif
+ if(date - buf.st_mtime < 3L*24L*60L*60L) { /* recent */
+ #ifndef NETWORK
+ extern int errno;
--- /dev/null Mon Jun 1 10:22:27 2026
+++ patches/patch-src_hacklib_c Mon Jun 1 10:18:15 2026
@@ -0,0 +1,60 @@
+Index: src/hacklib.c
+--- src/hacklib.c.orig
++++ src/hacklib.c
+@@ -444,14 +444,7 @@ setrandom()
+ srandom((unsigned int) time((time_t *)0));
+ #else
+ # if defined(BSD) || defined(ULTRIX) || defined(CYGWIN32) /* system srandom()
*/
+-# ifdef BSD
+-# if defined(SUNOS4)
+- (void)
+-# endif
+- srandom((int) time((long *)0));
+-# else
+- srandom((int) time((time_t *)0));
+-# endif
++ srandom((int) time(NULL));
+ # else
+ # ifdef UNIX /* system srand48() */
+ srand48((long) time((time_t *)0));
+@@ -467,16 +460,8 @@ getlt()
+ {
+ time_t date;
+
+-#ifdef BSD
+- (void) time((long *)(&date));
+-#else
+ (void) time(&date);
+-#endif
+-#if (defined(ULTRIX) && !(defined(ULTRIX_PROTO) || defined(NHSTDC))) ||
defined(BSD)
+- return(localtime((long *)(&date)));
+-#else
+ return(localtime(&date));
+-#endif
+ }
+
+ int
+@@ -497,11 +482,7 @@ time_t date;
+ if (date == 0)
+ lt = getlt();
+ else
+-#if (defined(ULTRIX) && !(defined(ULTRIX_PROTO) || defined(NHSTDC))) ||
defined(BSD)
+- lt = localtime((long *)(&date));
+-#else
+ lt = localtime(&date);
+-#endif
+
+ Sprintf(datestr, "%02d%02d%02d",
+ lt->tm_year, lt->tm_mon + 1, lt->tm_mday);
+@@ -519,11 +500,7 @@ time_t date;
+ if (date == 0)
+ lt = getlt();
+ else
+-#if (defined(ULTRIX) && !(defined(ULTRIX_PROTO) || defined(NHSTDC))) ||
defined(BSD)
+- lt = localtime((long *)(&date));
+-#else
+ lt = localtime(&date);
+-#endif
+
+ /* just in case somebody's localtime supplies (year % 100)
+ rather than the expected (year - 1900) */
--- /dev/null Mon Jun 1 10:22:34 2026
+++ patches/patch-src_u_init_c Mon Jun 1 10:18:21 2026
@@ -0,0 +1,15 @@
+Index: src/u_init.c
+--- src/u_init.c.orig
++++ src/u_init.c
+@@ -576,11 +576,7 @@ u_init()
+ aligns[flags.initalign].value;
+ u.ulycn = NON_PM;
+
+-#ifdef BSD
+- (void) time((long *)&u.ubirthday);
+-#else
+ (void) time(&u.ubirthday);
+-#endif
+
+ /*
+ * For now, everyone starts out with a night vision range of 1 and
