Le Fri, Sep 04, 2026 at 04:39:48PM +0100, Leah Rowe a écrit :
> 
> your three dots are deserved, at the end there. it even occured to me while
> writing, that openbsd very likely already implements all that stuff itself.
> 
> if you want to omit --enable-hardening and --enable-stl-hardening, that's
> fine. i just added them because i thought, yeah why not.
> 
> really then the only flags that i can think of that openbsd might find
> worthwhile on the ports are:
> 
> --enable-rust-simd

what does this bring, and what are the potential downsides ?
incompatibilities with rust versions ? afaict that's a knob pushed on by
default upstream, so why not. cf
https://searchfox.org/firefox-main/source/build/mozconfig.rust#1 &
https://searchfox.org/firefox-main/source/build/mozconfig.common#22,
that might already by included by librewolf ? *shrug*

> (the tests/crashreporter disablement are optional really)

the crashreporter is already disabled by default:
https://searchfox.org/firefox-main/source/toolkit/moz.configure#3455

as for tests, really but no thanks, the tests are useful sometimes, at
least to me, cf
https://github.com/openbsd/ports/commit/804da332adc2853a47ea0943b2397b9d63e795d0
&
https://github.com/openbsd/ports/commit/4d03e87c26820c31d769694b30c9f4d3b977ec73

> -ftrivial-auto-var-init=zero <-- this one, in the patch, might still be
> desirable. not sure if openbsd does that in its compilers.

i have no idea what this does. do you ? there are some references
upstream, cf
https://searchfox.org/firefox-main/source/build/moz.configure/toolchain.configure#2907

generally speaking, i tend to avoid pushing knobs when i dunno what they
do. and i avoid diverting from upstream for the sake of "we're special"
because it can lead to self-inflicted harm later on.

and as i already said, if things have to be factorized, that's in
mozilla.port.mk. no point in duplicating the same lines in 4 or 5
makefiles...

Reply via email to