Hi,

After taking another glance at this I realized that the default
TEST_TARGET is inappropriate for this port. After correcting it, test
both runs and passes. I think that not having any go files in the
root directory trips it up because running go test from your standard
workspace also doesn't work as-is.

Another diff below. Someone please review and commit if this is the
appropriate approach (I don't think this change requires a revision
bump).

On Tue Sep 1, 2026 at 8:42 PM CEST, Volker Schlecht wrote:
> Thanks, committed. AFAICT it *has* tests (i.e. in internal/bundler_tests).
>
> On 9/1/26 5:28 PM, Igor Zornik wrote:
>> Ping.
>> 
>> On Tue Aug 25, 2026 at 7:32 PM CEST, Igor Zornik wrote:
>>> Hello, ports.
>>>
>>> A new version of esbuild with a few stylistic changes to the Makefile.
>>> JS and CSS bundling tested on today's amd64 snap. QP-encoded diff below
>>> the changelog. Someone please commit if OK.
>>>
>>> Out of curiosity I ran make test and got the following error:
>>>
>>> no required module provides package github.com/evanw/esbuild; to add it:
>>>      go get github.com/evanw/esbuild
>>> FAIL    github.com/evanw/esbuild [setup failed]
>>>
>>> Does this make it a candidate for NO_TEST?
>>>
>>> Changelog:
>>> - Fix tree shaking bug due to TypeScript import alias.
>>> - Fix CSS minification bug involving '&'.
>>> - Avoid overwriting input files without '--allow-overwrite'.
>>> - Fix incorrect code generated when using top-level await.
>>> - Fix a minification bug with lowered logical assignment operators.
>>> - Fix a potential deadlock when the JavaScript API is used incorrectly.
>>> - Handle target collisions.
>>> - Force '.mp3' files to use the 'audio/mpeg' MIME type.
>>> - Add a new TypeScript syntax warning.
>>> - Add support for formatting errors for Visual Studio.
>>> - Fix a bug with CSS gamut mapping.
>>>
>>> Detailed changelog is available at
>>> https://github.com/evanw/esbuild/releases/tag/v0.28.2
>>>

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/esbuild/Makefile,v
retrieving revision 1.22
diff -u -p -u -p -r1.22 Makefile
--- Makefile    1 Sep 2026 18:35:41 -0000       1.22
+++ Makefile    8 Sep 2026 16:45:20 -0000
@@ -18,6 +18,8 @@ WANTLIB += c pthread
 
 MODULES =      lang/go
 
+TEST_TARGET =  ./...
+
 .include "modules.inc"
 
 .include <bsd.port.mk>

Reply via email to