23.09.2026 15:53, Nazarenko Mykyta пишет:
> Hola ports@, kirill@, kn@.
>
> The new versions of net/tdesktop and net/64gram now require tlottie
> instead of rlottie; the upstream, in turn, has made it impossible to build
> this library as an bundled option because it is written in Rust.
>
> As you know, this library is used to render lottie animations, and it does
> so much faster than rlottie.
>
> Tested it with 64gram 1.2.10, works fine.
>
> With best regards,
> Nazarenko Mykyta
Thanks for the port, looks good to go with a few tweaks:
- variables before targets
- no need to create common dirs
- INSTALL_PROGRAM for .so files would set +x
Questions:
- Why the 'c-api' feature which is 'cpu' as opposed to
the default 'cpu', 'std'? What's up with 'std'?
If that's required by tdesktop, a comment should explain that.
Style nits, as you like:
- For wantlib i either copy from port-lib-depends-check as-is
or consistently assign (not amend) and indent, you did a mix.
- Fewer empty lines? I'd group, e.g. MOD* and includes.
Tests mostly pass, did you look at the failures?
Just wondering, I'm fine with importing as-is:
failures:
dos::animated_repeater_product_stays_bounded
dos::animated_unique_lut_gradient_fills_stay_bounded
dos::clipped_dashed_round_join_zigzag_stays_bounded
dos::compounding_repeaters_are_rejected
dos::many_clipped_dashed_strokes_stay_bounded
dos::many_max_depth_parent_chains_stay_bounded
dos::max_legal_cumulative_shape_paints_stay_bounded
dos::nested_track_matte_target_surfaces_stay_bounded
dos::overshooting_easing_dashed_path_stays_bounded
dos::pr11_dashed_polystar_tiny_period_stays_bounded
dos::renderer_rejects_large_canvas_before_allocating_fallback
dos::reused_precomp_auto_orient_spatial_timeline_stays_bounded
dos::reused_precomp_auto_orient_split_position_timelines_stay_bounded
dos::reused_precomp_layer_opacity_timeline_stay_bounded
dos::reused_precomp_spatial_position_timelines_stay_bounded
dos::reused_precomp_unsorted_fill_properties_stay_bounded
test result: FAILED. 234 passed; 16 failed; 0 ignored; 0 measured; 0 filtered
out; finished in 16.25s
diff --git a/graphics/tlottie/Makefile b/graphics/tlottie/Makefile
index fcd26b663..1adc11a99 100644
--- a/graphics/tlottie/Makefile
+++ b/graphics/tlottie/Makefile
@@ -14,25 +14,19 @@ HOMEPAGE = https://github.com/dkaraush/tlottie
# MIT
PERMIT_PACKAGE = Yes
-WANTLIB += ${MODCARGO_WANTLIB} m
+WANTLIB = ${MODCARGO_WANTLIB} m
-MODULES += devel/cargo
-
-MODCARGO_FEATURES = c-api
+MODULES = devel/cargo
CONFIGURE_STYLE = cargo
+SEPARATE_BUILD = Yes
MODCARGO_INSTALL = No
do-install:
- ${INSTALL_DATA_DIR} ${PREFIX}/include
${INSTALL_DATA} ${WRKSRC}/include/tlottie.h ${PREFIX}/include/
- ${INSTALL_DATA_DIR} ${PREFIX}/lib
- ${INSTALL_PROGRAM} ${MODCARGO_TARGET_DIR}/release/libtlottie.so \
+ ${INSTALL_DATA} ${MODCARGO_TARGET_DIR}/release/libtlottie.so \
${PREFIX}/lib/libtlottie.so.${LIBtlottie_VERSION}
-SEPARATE_BUILD = Yes
-
.include "crates.inc"
-
.include <bsd.port.mk>
