On 2026/09/28 16:09, David Uhden Collado wrote:
> It should also make future github-cli updates easier. When the survey
> dependency changes, the patches can be tested directly against the new
> upstream version and refreshed or removed if they are no longer needed,
> without having to maintain and update a separate fork first.
survey is abandoned upstream so this isn't really a consideration.
(and if it wasn't abandoned we'd probably be able to get this fix
committed upstream anyway..)
> +post-extract:
> + ${UNZIP} -oq ${DISTDIR}/go_modules/${SURVEY_MOD}/@v/${SURVEY_V}.zip \
> + -d ${WRKDIR}/survey-extract
> + mv
> ${WRKDIR}/survey-extract/github.com/AlecAivazis/survey/v2@${SURVEY_V} \
> + ${WRKDIR}/survey
> + rm -rf ${WRKDIR}/survey-extract
> +
> +post-patch:
> + patch -d ${WRKDIR}/survey -p0 \
> + < ${FILESDIR}/patch-survey_terminal_runereader_posix_go
> + patch -d ${WRKDIR}/survey -p0 \
> + < ${FILESDIR}/patch-survey_go_mod
it would indeed be nice to have a proper way to patch go modules
and, if we had that, moving from the fork to port patches would make
sense. that would be useful for much more than just github-cli.
but this approach with ${FILESDIR} and these custom targets isn't
really a sustainable properly-integrated way to do this.
