On Fri, Sep 25, 2026 at 08:39:11PM -0400, Brad Smith wrote:
> Now that Clang has been fixed this now builds fine on riscv64.

At the risk of stating the obvious: I added these lines, please Cc
when removing them.

> Index: devel/highway/Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/highway/Makefile,v
> retrieving revision 1.11
> diff -u -p -u -p -r1.11 Makefile
> --- devel/highway/Makefile    25 Jul 2026 08:29:28 -0000      1.11
> +++ devel/highway/Makefile    4 Sep 2026 19:51:57 -0000
> @@ -4,7 +4,7 @@ GH_ACCOUNT =  google
>  GH_PROJECT = highway
>  GH_TAGNAME = 1.4.0
>  
> -REVISION =   0
> +REVISION =   1
>  
>  CATEGORIES = devel
>  
> @@ -26,13 +26,6 @@ WANTLIB += ${COMPILER_LIBCXX} m
>  
>  CONFIGURE_ARGS +=    -DHWY_SYSTEM_GTEST=ON \
>                       -DBUILD_SHARED_LIBS=ON
> -
> -.if ${MACHINE_ARCH} == riscv64
> -# The riscv Vector code does not build because of a long vs long long 
> mismatch
> -CXXFLAGS +=          -DHWY_BROKEN_RVV=HWY_RVV

> -# Don't assume risc-v Vector support
> -CONFIGURE_ARGS+=     -DHWY_CMAKE_RVV=OFF

This has to stay, we don't want to assume that the vector feature is
available.

I had another diff that was more complete.

> -.endif
>  
>  # everything except tests
>  ALL_TARGET = ${SHARED_LIBS:Mhwy*}
> 

-- 
jca

Reply via email to