On Fri, Oct 23, 2026 at 09:03:03PM -0700, Thomas Frohwein wrote:
> On Sat, 17 Oct 2026 18:19:11 +0200
> Marc Espie <[email protected]> wrote:
>
> > Contrary to the comments in your patch, it does not say it actually
> > sets WRKDIST, nor do you give examples, contrary to the other
> > templates.
> >
> > It's also not really clear for me (again from your patch) what's the
> > rationale behind the actual values for github and codeberg.
> >
> > Also, it puts two variables inside the DIST_TUPLE description
> > (TEMPLATE_EXTRACT_DIR and ID_MOD), they should have independent
> > entries. It's not clear at all how all these are related.
> >
> > At this point, I think that the DIST_TUPLE stuff would benefit from
> > having its own subsection in bsd.port.mk(5).
> >
> > e.g., just say in the main body that DIST_TUPLE is used for various
> > forges and reference the other variables in there (TEMPLATE*).
> >
> > Also put a one-liner for each template, and group everything together
> > in a
> > .Ss THE DIST_TUPLE FRAMEWORK
> > subsection.
> >
> > You could in particular document each substitution pattern
> > appropriately, and how all the variables relate to each other.
> >
> >
> > e.g, the main document would have something like
> >
> > .Ev DIST_TUPLE
> > Framework for fetching
> > .Ev DISTFILES
> > from one of the forges.
> > May also use
> > .Ev ID_MOD.* ,
> > .Ev TEMPLATE_DISTFILES.* ,
> > .Ev TEMPLATE_EXTRACT_DIR.* ,
> > .Ev TEMPLATE_HOMEPAGE.*
> > for proper behavior.
> > See
> > .Sx THE DIST_TUPLE FRAMEWORK
> > section below.
> >
> > ...
> >
> > .Ev ID_MOD.*
> > Part of
> > .Sx THE DIST_TUPLE_FRAMEWORK
> >
> > ...
> >
> > Then you can document it properly in one single section.
>
> New bsd.port.mk.5 diff below. If this or something building on it ends
> up going in, I think we could remove the comments in dist-tuple.pattern
> that are essentially stating the same thing. The duplication risks
> being a source of future confusion otherwise.
>
100% yes. Basic guideline is to only leave implementation comment in *.mk
files that have zero business in the man page.