On 2026/10/29 11:43, Stefan Sperling wrote: > On Thu, Oct 29, 2026 at 10:45:03AM +0100, Theo Buehler wrote: > > I think your approach is about as clean as it can be. I'm not terribly > > fond of the MODCARGO_configure call in post-configure though. > > This is because setting CONFIGURE_STYLE=cargo breaks the steps where > the lang/go module is moving build directories around. > > > I don't have a better idea. > > Me neither.
When you're doing anything that's slightly outside of normal MODULES (i.e. cargo and another module together) then calling the MODxxx_configure target explicitly seems the cleanest way to me. On 2026/10/29 10:00, Stefan Sperling wrote: > On Wed, Oct 28, 2026 at 11:16:45PM +0100, Theo Buehler wrote: > > > > Pretty sure you can skip this. You have bdeps on lang/rust and lang/go > > from their use in the modules, so you already get the intersection of > > the two architectures from their respective ONLY_FOR_ARCHS, and this > > excludes i386 because i386 is not in RUST_ARCHS. > > What you're saying is correct, though there is another reason for > setting ONLY_FOR_ARCHS: The linker flags we're adding for cgo are > architecture-specific, and we currently only cover amd64 and arm64 > in our patches. Any other architecture would fail to link the binaries > due to missing symbols required by the RDP library. Even without the rust parts, the go part doesn't build on i386 anyway, out of ram.
