On Sat, Oct 31, 2026 at 02:54:44PM +0100, Kirill A. Korinsky wrote:
> On Tue, 27 Oct 2026 13:17:23 +0100,
> Martijn van Duren <[email protected]> wrote:
> >
> > -fpic doesn't fit for alpha, use -fPIC instead.
> > Fix suggested by kirill@.
> >
> > OK?
> >
>
> Not sure do you need a revision bump for this, but to stay on safe side I
> suggested to add it.
Using -fPIC instead of -fpic changes the way the code is generated, so
a REVISION bump is warranted.
> Anyway, it builds fine on amd64 and passed make test
>
> Also, make check-shlib-syms reports nothing.
>
> So, OK kirill@
I'd prefer this version instead, it uses -fPIC instead of -fpic on
archs where it makes sense, and mimics what we do for the base system
and a bunch of other ports. If you agree, please commit it with my
ok.
Index: Makefile
===================================================================
RCS file: /home/cvs/ports/security/rhash/Makefile,v
diff -u -p -r1.18 Makefile
--- Makefile 16 May 2025 23:09:05 -0000 1.18
+++ Makefile 31 Oct 2026 15:00:59 -0000
@@ -3,6 +3,7 @@ COMMENT = utility and library for comput
GH_ACCOUNT = rhash
GH_PROJECT = RHash
GH_TAGNAME = v1.4.6
+REVISION = 0
PKGNAME = ${DISTNAME:L}
SHARED_LIBS = rhash 1.1
@@ -31,6 +32,9 @@ DEBUG_PACKAGES = ${BUILD_PACKAGES}
FAKE_FLAGS = SYSCONFDIR=${WRKINST}${PREFIX}/share/examples/rhash
TEST_DEPENDS = sysutils/ggrep
+
+# PICFLAG is defined in bsd.own.mk
+SUBST_VARS += PICFLAG
pre-configure:
${SUBST_CMD} ${WRKSRC}/common_func.h \
Index: patches/patch-configure
===================================================================
RCS file: /home/cvs/ports/security/rhash/patches/patch-configure,v
diff -u -p -r1.9 patch-configure
--- patches/patch-configure 14 May 2025 07:42:43 -0000 1.9
+++ patches/patch-configure 31 Oct 2026 14:54:52 -0000
@@ -21,3 +21,19 @@ Index: configure
fi
#####################################################################
+@@ -831,7 +831,7 @@ elif darwin; then
+ LIBRHASH_SH_CFLAGS="-fpic"
+ LIBRHASH_SH_LDFLAGS='-dynamiclib -Wl,-install_name,$(LIBDIR)/$@'
+ else
+- LIBRHASH_SH_CFLAGS="-fpic"
++ LIBRHASH_SH_CFLAGS="${PICFLAG}"
+ LIBRHASH_SH_LDFLAGS="-shared
-Wl${SHARED_VSCRIPT},-soname,\$(LIBRHASH_SO_MAJ)"
+ test -n "$SHARED_VSCRIPT" && LIBRHASH_EXPORTS_TARGET=$LIBRHASH_EXPORTS_FILE
+ fi
+@@ -1058,4 +1058,4 @@ if test -f "${MAN_PATH}.in"; then
+ SED_SYSCONFDIR=$(echo $INSTALL_SYSCONFDIR | sed -e 's/\([|\\&]\)/\\\1/g')
+ echo "Writing ${MAN_PATH}"
+ sed -e "s|@SYSCONFDIR@|$SED_SYSCONFDIR|" ${MAN_PATH}.in > ${MAN_PATH}
+-fi
+\ No newline at end of file
++fi
--
jca
