On 2026-11-08, Anthony J. Bentley wrote:
> Personally, I would prefer that the directory and PKGNAME be lowercased.
> This is the case for most ports in tree, even when the binary has
> uppercase letters.
Ok.
Should the binary and/or the doc directory (${PREFIX}/share/doc/prboomX)
also be lowercase? Or should these be kept as upstream installs?
For the doc directory, i think it must be named just like PKGNAME, for
the user to identify the docs. But for the binaries, i am not sure if
we should break upstream's naming.
> CFLAGS += -I${X11BASE}/include is not ideal, because if someone builds
> with 'make CFLAGS=...' the option gets lost. Upstream should fix this
> properly by doing the right cmake magic for it to pick up the include
> headers from pkg-config. But in the meantime, you can add this to
> CONFIGURE_ARGS: -DCMAKE_C_FLAGS="${CFLAGS} -I${X11BASE}/include"
>
> As with all ports that use GL, 3D graphics, etc., I strongly recommend
> enabling debug packages. If a crash occurs inside a graphics driver,
> it will be difficult for a developer to reproduce the crash without the
> exact same graphics hardware, so we want to make it as easy as possible
> for the user to provide a full backtrace. So, please set DEBUG_PACKAGES =
> ${BUILD_PACKAGES}.
I have fixed these locally, and will send a final port when my question
above get answered.