Timo Myyrä writes:
> This should replace the existing games/gzdoom port.

I don't know about that. Sometimes these "community forks" don't last.
Remember libav versus ffmpeg, or mplayer2 versus mplayer?

> Slightly tested on amd64 and works for me.
>
> Thoughts?

As with any GL port, I strongly recommend enabling debug symbols with
DEBUG_PACKAGES=${BUILD_PACKAGES}. Since if a crash occurs deep in the
graphics stack, it won't be reproducible without similar hardware, so
we want to make it as easy as possible for a user to provide a proper
backtrace.

Overriding CFLAGS like this:
CFLAGS +=               -I${X11BASE}/include
CXXFLAGS +=             -I. -I${LOCALBASE}/include
means that the build will fail if the user building the port manually
overrides CFLAGS ("make CFLAGS=..."). For a cmake port, it's better to
add to CONFIGURE_ARGS:

        -DCMAKE_C_FLAGS="${CFLAGS} -I${X11BASE}/include"
        -DCMAKE_CXX_FLAGS="${CXXFLAGS} -I. -I${LOCALBASE}/include"

The license marker should be GPLv3+, not GPLv3. However, compared to
gzdoom this version mass-relicensed over 700 BSD-licensed files to
GPLv3+. That is extremely lame, and possibly illegal.

Reply via email to