On Sun, 15 Nov 2026 20:42:00 +0100,
Nazarenko Mykyta <[email protected]> wrote:
> 
> [1  <text/plain; UTF-8 (quoted-printable)>]
> On Sun, 15 Nov 2026 17:22:38 +0000
> Klemens Nanni <[email protected]> wrote:
> 
> > 
> > Feedback?  OK to import?
> > 
> 
> This solution is more good than bad, but the only thing that bothers me 
> is the unpredictability of tdesktop upstream and its related components
> - if they feel like it, they might suddenly remove or change something.
> 
> Overall, it’s better to automate this process, and yes, we’ll be able to 
> patch a buggy patch if upstream decides to break something - but only
> if they don’t decide to do something truly crazy.
> 
> I agree that we should import this variant.
> 
> 
> > +# keep in sync with net/tdesktop
> > +TD_TAG =           v7.4.4
> > +TD_SNAP_YAML =             
> > https://github.com/telegramdesktop/tdesktop/raw/refs/tags/${TD_TAG}/snap/snapcraft.yaml
> > +# see get-patch-ver target
> 
> # see get-patch-ver target -> # see get-patch-commit target
> 
> > +TD_PATCH_COMMIT =  23d349a3ff09dbc1fa8127ce39ba9223de0edf21
> > +PATCHFILES.td =            ${TD_PATCH_COMMIT}{wallet-engine}.patch
> > +SITES.td =         
> > https://github.com/desktop-app/patches/raw/${TD_PATCH_COMMIT}/
> > +PATCH_DIST_STRIP = -p1
> > +
> >  CATEGORIES =               devel
> >  
> >  SHARED_LIBS =              wallet_engine  0.0
> > @@ -19,6 +28,12 @@ MODULES =                devel/cargo
> >  
> >  CONFIGURE_STYLE =  cargo
> >  
> > +BUILD_DEPENDS =            textproc/yq
>  
> I don't think that we need to put textproc/yq into the BUILD_DEPENDS.
> It's because this target will be used only by maintainer or a gentleman
> who will try to update this stuff. 
> 
> Thanks kn@ :) Tarball attached.
> 

OK kirill@ to import it

-- 
wbr, Kirill

Reply via email to