On Tue, Dec 11, 2007 at 08:06:32PM +0200, Mikko Tolmunen wrote:
> yEnc encoding/decoding extension for Python
> tested on i386.
Some quick comments:
* Missing comment at top of Makefile (see
/usr/ports/template/Makefile.template)
* ${VERSION} is useless here
* ${DISTNAME:S/^/py-/} is nicer for PKGNAME (IMHO)
* s/significatively/significantly/ in pkg/DESCR
* regress target fails for me on -current/i386:
===> Regression check for py-yenc-0.3
cd /usr/ports/mystuff/py-yenc/w-py-yenc-0.3/yenc-0.3/test &&
/usr/local/bin/python2.5 test.py
Traceback (most recent call last):
File "test.py", line 27, in <module>
import yenc
ImportError: No module named yenc
*** Error code 1
Stop in /usr/ports/mystuff/py-yenc (line 21 of Makefile).
Did regress work when you tested the port? I'll look more into this
in a bit...
--
o--------------------------{ Will Maier }--------------------------o
| web:.......http://www.lfod.us/ | [EMAIL PROTECTED] |
*------------------[ BSD Unix: Live Free or Die ]------------------*
