Hi,

Few comments,

On Thu, 10 Jan 2008 03:42:38 +0200 Mikko Tolmunen wrote:
> tested on i386

First, I want to admit that I didn't try to build your port. :)

Instead, I have been running my own pretty similar monotone-0.38 port.
Monotone 0.38 itself has behaved well on my -current/i386 system.

> full changelog available at http://www.monotone.ca/NEWS
> 
>           If building from source, you will still need the Boost headers
>           available somewhere.  See INSTALL for details.
[snip]
> +BUILD_DEPENDS=       ::devel/boost

Would it be better to change this to
BUILD_DEPENDS=          :boost-headers->=1.33.0:devel/boost
?

This way one could pkg_add only the headers and then compile the port.

Another thing (in the resulting port after applying the patch):
> WANTLIB += c m pthread stdc++ z

Monotone doesn't need pthread library. 
WANTLIB += c m stdc++ z
should be enough.

$ ldd `which mtn`
/usr/local/bin/mtn:
        Start    End      Type Open Ref GrpRef Name
        00000000 00000000 exe  1    0   0      /usr/local/bin/mtn
        09499000 294a1000 rlib 0    1   0      /usr/lib/libz.so.4.1
        0af35000 2af5b000 rlib 0    1   0      /usr/lib/libstdc++.so.44.0
        06874000 2687b000 rlib 0    1   0      /usr/lib/libm.so.2.3
        03d1a000 23d4e000 rlib 0    1   0      /usr/lib/libc.so.42.0
        00916000 00916000 rtld 0    1   0      /usr/libexec/ld.so
$

> cvs server: Diffing patches
> cvs server: cannot find patches/patch-configure

Yeah, no need for patches anymore.

-- 
Tero Koskinen - http://iki.fi/tero.koskinen/

Reply via email to