On Wed, Mar 19, 2008 at 06:51:58AM -0400, Olivier Cherrier wrote:
> On Wed, Mar 19, 2008 at 09:21:16AM +0100, [EMAIL PROTECTED] wrote:
> >>    http://www.symacx.com/data/software/OpenBSD/shmux.taz
> >
> > Not very important but..:
> >
> > - You could also reuse homepage to define master_sites.
> > i.e. MASTER_SITES=${HOMEPAGE}/dist/
> 
> Done.
> 
> > - Also, the RCS tag is wrong, it should be $OpenBSD$ (without the ':' you 
> > added).
> 
> Done.
> It works without any problem with the ':'.  That's the case with GNU cvs
> as well as OpenCVS.
> When the variable has been expanded, it looks like:
>       $OpenBSD: Makefile,v 1.49 2006/02/08 17:27:49 steven Exp $
> 
> > - As for the strlcpy and friends patches, we decided not to bother with 
> > this for ports as I makes the maintenance more complicated. You are 
> > encouraged to put them upstream though ;-)
> 
> OK, I will do it.
> For now, I just stripped down the patches.
> Archive updated.

And it seems that it has fping as a hidden RUN_DEPENDS (use -P switch),
but wh ship it as only executable by root..
Also, i'd prefer ALL_TARGET=shmux for the sake of clarification, and
also REGRESS_TARGET=test to have make regress happy.
Simon@ pointed out that PERMIT_DISTFILE_CDROM could be set to no, as
clause (1) speaks about 'reasonable fee'.. but anyway we don't ship
distfiles on CDROM. I'm not a licence expert, but this licence scares me. 

Landry

Reply via email to