On Mon, Mar 31, 2008 at 03:58:25PM +0200, Jonathan Schleifer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: RIPEMD160
>
> "Federico G. Schwindt" <[EMAIL PROTECTED]> wrote:
>
> > Index: audio/audacious/patches/patch-m4_buildsys_m4
> > ===================================================================
> > RCS file: audio/audacious/patches/patch-m4_buildsys_m4
> > diff -N audio/audacious/patches/patch-m4_buildsys_m4
> > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > +++ audio/audacious/patches/patch-m4_buildsys_m4 31 Mar 2008
> > 01:10:45 -0000 @@ -0,0 +1,20 @@
> > +$OpenBSD$
> > +--- m4/buildsys.m4.orig Thu Mar 13 22:19:27 2008
> > ++++ m4/buildsys.m4 Sun Mar 23 06:10:48 2008
> > +@@ -106,14 +106,14 @@ AC_DEFUN([BUILDSYS_SHARED_LIB], [
> > + AC_MSG_RESULT(POSIX)
> > + LIB_CPPFLAGS='-DPIC'
> > + LIB_CFLAGS='-fPIC'
> > +- LIB_LDFLAGS='-shared -fPIC
> > -Wl,-soname,${LIB}.${LIB_MAJOR}' ++
> > LIB_LDFLAGS='-shared -fPIC -Wl,-soname,${LIB}'
> > + LIB_PREFIX='lib'
> > + LIB_SUFFIX='.so'
> > + PLUGIN_CPPFLAGS='-DPIC'
> > + PLUGIN_CFLAGS='-fPIC'
> > + PLUGIN_LDFLAGS='-shared -fPIC'
> > + PLUGIN_SUFFIX='.so'
> > +- INSTALL_LIB='${INSTALL} -m 755 $$i
> > ${DESTDIR}${libdir}/$$i.${LIB_MAJOR}.${LIB_MINOR}.0 && ${LN_S} -f
> > $$i.${LIB_MAJOR}.${LIB_MINOR}.0 ${DESTDIR}${libdir}/$$i.${LIB_MAJOR}
> > && ${LN_S} -f $$i.${LIB_MAJOR}.${LIB_MINOR}.0
> > ${DESTDIR}${libdir}/$$i' ++
> > INSTALL_LIB='${INSTALL} -m 755 $$i ${DESTDIR}${libdir}/$$i'
> > + UNINSTALL_LIB='rm -f
> > ${DESTDIR}${libdir}/$$i ${DESTDIR}${libdir}/$$i.${LIB_MAJOR}
> > ${DESTDIR}${libdir}/$$i.${LIB_MAJOR}.${LIB_MINOR}.0'
> > + CLEAN_LIB=''
> > + ;;
>
> I'm the creator of the build system Audacious uses and I'm very unhappy
> with this change. Why do you change the POSIX target when there is an
> OpenBSD target? Doesn't the OpenBSD target work? Last time I tested it
> on OpenBSD, it worked for me. Please patch the OpenBSD target if it
> doesn't work and let me know. Feel free to mail me privately about the
> build system.
This was done for simplicity. The target does not work and it also includes
netbsd and solaris, and that's how it was done before. This is not mean to
be submitted anyways, but if you really want it I will prepare a diff and
send it to you.
> For the patches on some .c files, you should file bugs so we can look
> if we can commit them.
As I said in the email, they're already submitted (one already commited).
Thanks,
f.-
