On Tue, Apr 08, 2008 at 07:37:50PM +0200, Tobias Ulmer wrote: > On Tue, Apr 08, 2008 at 12:34:07PM -0400, Mike Erdely wrote: > > As jasper@ pointed out to me, the dwm diff does not require the updated > > dmenu diff: > > It does, dmenu_run is new. We could replace it with the old > dmenu_path | dmenu construct, but that would be silly.
Ugh. I had a misplaced "not" in my sentence. > My 2 cents: > - remove pre-patch target > - remove patch-Makefile, doesn't do anything except eye candy > - patch config.def.h directly, also use tags[8] instead of "9", like the > the rest of the config. > - remove patch-config_h > - for config.mk, don't += LDFLAGS, they're not supposed to be > configurable like CFLAGS in a port. I don't know how that slipped in there. That was a mistake. > - Don't hardcode CC This diff looks good and works for me. ok? -ME
