On 2008/10/03 09:12, Don Jackson wrote:
>
> Here is a first draft of a new port for s3sync.
> Please test/comment.
> I have installed it on a couple of machines running OpenBSD 4.3 stable, 
> amd64
> This is my first port, so I will not be surprised if I have more to learn 
> about doing this properly.
>
> http://s3sync.net/wiki
>
> DESCR:
>
> s3sync is a ruby program that easily transfers directories between a  
> local
> directory and an Amazon S3 bucket:prefix. It behaves somewhat, but not
> precisely, like the rsync program. It also includes s3cmd, a program that 
> wraps
> S3 operations into a simple command-line tool.
>
>

I don't have time to look further but some quick comments -


Missing $OpenBSD$ marker

> COMMENT=        "Sync tool for Amazon's S3 storage service"

No more double-quotes surrounding COMMENT

> DISTNAME=       s3sync-1.2.5
> PKGNAME=        ${DISTNAME}

PKGNAME defaults to DISTNAME, we leave it out unless
overriding it with something different.

> CATEGORIES=     net
> 

Missing license marker comment

> PERMIT_PACKAGE_CDROM=   Yes
> PERMIT_PACKAGE_FTP=     Yes
> PERMIT_DISTFILES_CDROM= Yes
> PERMIT_DISTFILES_FTP=   Yes
> 
> HOMEPAGE=       http://s3sync.net/wiki
> MASTER_SITES=   ${MASTER_SITE_RUBYFORGE:=s3sync/}
> 
> MODULES=        lang/ruby
> 
> CONFIGURE_STYLE=ruby gem
> 
> RUN_DEPENDS=    :ruby-iconv->=1.8.4:lang/ruby,-iconv,no_x11
> 
> PKG_ARCH=       *
> 
> .include <bsd.port.mk>
> 

and please follow Makefile.template style for new ports
(space before =)

Reply via email to