Trying again. Any comments?

On Tue, Aug 12, 2008 at 04:05:14PM +0100, Mikolaj Kucharski wrote:
> I like the way it works with my patch, as currently it has some issues,
> one of them is showed below.
> 
> 
> # grep -A6 ^bzip2 /usr/ports/distfiles/Makefile
> bzip2-1.0.5.tar.gz: $F
>         @[EMAIL PROTECTED]; ${SIMPLE_LOCK}; \
>          MAINTAINER="The OpenBSD ports mailing-list <[email protected]>" \
>          SITES="http://www.bzip.org/1.0.5/ 
> ftp://ftp.openbsd.org/pub/OpenBSD/distfiles// 
> ftp://ftp.usa.openbsd.org/pub/OpenBSD/distfiles//"; \
>          CIPHER="sha256" CKSUM="979TaDCdduXa86idTRvqaI2sd4B0LnoK4a8ZvpMW/iI=" 
> CHECK="SHA256 (bzip2-1.0.5.tar.gz) = 
> 979TaDCdduXa86idTRvqaI2sd4B0LnoK4a8ZvpMW/iI=" \
>          ${EXEC} ${FETCH} "$@"
> 
> 
> $CIPHER is set to "sha256" but..
> 
> # sha256 < bzip2-1.0.5.tar.gz
> /bin/ksh: sha256: not found

-- 
best regards
q#
Index: check-all
===================================================================
RCS file: /cvs/ports/infrastructure/fetch/check-all,v
retrieving revision 1.1
diff -u -r1.1 check-all
--- check-all   4 Mar 2000 17:58:32 -0000       1.1
+++ check-all   12 Aug 2008 14:54:31 -0000
@@ -28,14 +28,14 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 if [ -f "$1" ] 
 then
-       case `${CIPHER} <$1` in
-       ${CKSUM}) 
+       if echo "${CHECK}" | cksum -qc
+       then
                echo "Ok: $1"
-               exit 0;;
-       *) 
+               exit 0
+       else
                echo "Bad checksum: $1" 
-               exit 1;;
-       esac
+               exit 1
+       fi
 fi
 echo "Missing: $1"
 exit 1

Reply via email to