On Sat, Nov 15, 2008 at 09:27:07AM +0100, Cesare Gargano wrote:
> On 14/11/08 13:26 +0100, Pierre-Emmanuel Andr? wrote:
> > Le Fri, 14 Nov 2008 13:03:42 +0100,
> > Giovanni Bechis <[EMAIL PROTECTED]> a ?crit :
> >
> > > Cesare Gargano wrote:
> > > > updated to 2.04
> > > >
> > > > during make I see: "Warning: prerequisite Test::Pod 1 not found."
> > > > should I include p5-Test-Pod?
> > > >
> > > I changed a bit the port (BUILD_DEPENDS), regression tests works
> > > @amd64. Cheers
> > > Giovanni
> > >
> > > P.S.: ask maintainer first.
> > >
> >
> > Another diff:
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/mail/p5-Mail-Tools/Makefile,v
> > retrieving revision 1.17
> > diff -u -p -r1.17 Makefile
> > --- Makefile 20 Feb 2008 03:35:13 -0000 1.17
> > +++ Makefile 14 Nov 2008 10:39:45 -0000
> > @@ -3,8 +3,8 @@
> > COMMENT= modules for handling mail with perl
> >
> > MODULES= cpan
> > -DISTNAME= MailTools-2.02
> > -PKGNAME= p5-Mail-Tools-2.02
> > +DISTNAME= MailTools-2.04
> > +PKGNAME= p5-Mail-Tools-2.04
> > CATEGORIES= mail devel
> > MASTER_SITES= ${MASTER_SITE_PERL_CPAN:=Mail/}
> >
> > @@ -16,6 +16,8 @@ PERMIT_DISTFILES_CDROM= Yes
> > PERMIT_DISTFILES_FTP= Yes
> >
> > RUN_DEPENDS= ::devel/p5-Time-TimeDate
> > +
> > +MAKE_ENV+= TEST_POD=Yes
> >
> > # Build examples as well
> > post-build:
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/mail/p5-Mail-Tools/distinfo,v
> > retrieving revision 1.7
> > diff -u -p -r1.7 distinfo
> > --- distinfo 20 Feb 2008 03:35:14 -0000 1.7
> > +++ distinfo 14 Nov 2008 10:39:45 -0000
> > @@ -1,5 +1,5 @@
> > -MD5 (MailTools-2.02.tar.gz) = gkvb5sQIRzmsLQBe67CbDg==
> > -RMD160 (MailTools-2.02.tar.gz) = SbdcJ1cCXp92NdAqiClhOp2CpNM=
> > -SHA1 (MailTools-2.02.tar.gz) = luXGr7POFJK77HHLzE8kdYEDdzM=
> > -SHA256 (MailTools-2.02.tar.gz) =
> > zDFQ25QA5rJpsgwUDe/s+OhNizBrqFQe1Kmi8V+JTJs=
> > -SIZE (MailTools-2.02.tar.gz) = 52013
> > +MD5 (MailTools-2.04.tar.gz) = 0h6k83XR5fPaawpOi6Hixg==
> > +RMD160 (MailTools-2.04.tar.gz) = eo0Unj08j8nmUWZZBjfu1RFbLLI=
> > +SHA1 (MailTools-2.04.tar.gz) = b8zQT52w9HjhnuwEe+O/Ch2Cl/U=
> > +SHA256 (MailTools-2.04.tar.gz) =
> > valzSyEjQ9jk7CdDqY4Tg/NU86K7im1tkxds8jPLIXE=
> > +SIZE (MailTools-2.04.tar.gz) = 52292
> >
> >
> > --
> > Pierre-Emmanuel Andr? <pea at raveland.org>
> > GPG key: 0x7AE329DC
> >
>
> works for me, regress ok @i386
> comments? ok?
>
Was there something wrong with the patch from [EMAIL PROTECTED]
Some comments inline...
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/mail/p5-Mail-Tools/Makefile,v
> retrieving revision 1.17
> diff -u -p Makefile
> --- Makefile 20 Feb 2008 03:35:13 -0000 1.17
> +++ Makefile 15 Nov 2008 08:23:40 -0000
> @@ -3,8 +3,8 @@
> COMMENT= modules for handling mail with perl
>
> MODULES= cpan
> -DISTNAME= MailTools-2.02
> -PKGNAME= p5-Mail-Tools-2.02
> +DISTNAME= MailTools-2.04
> +PKGNAME= p5-Mail-Tools-2.04
> CATEGORIES= mail devel
> MASTER_SITES= ${MASTER_SITE_PERL_CPAN:=Mail/}
>
> @@ -15,7 +15,12 @@ PERMIT_PACKAGE_FTP= Yes
> PERMIT_DISTFILES_CDROM= Yes
> PERMIT_DISTFILES_FTP= Yes
>
> -RUN_DEPENDS= ::devel/p5-Time-TimeDate
> +RUN_DEPENDS= ::devel/p5-Time-TimeDate \
> + ::devel/p5-Test-Pod
^^^^^^^^^^^^^^^^^
That's covered by MAKE_ENV+=TEST_POD=Yes, so need to add it (see
ports/infrastructure/mk/cpan.port.mk). And if it was a different port
and required, it would probably have to go to REGRESS_DEPENDS.
> +BUILD_DEPENDS= ${RUN_DEPENDS}
This doesn't seem necessary at all, the port still builds without those
installed (as in no Makefile.PL changes).
> +MAKE_ENV+= TEST_POD=Yes
>
> # Build examples as well
> post-build:
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/mail/p5-Mail-Tools/distinfo,v
> retrieving revision 1.7
> diff -u -p distinfo
> --- distinfo 20 Feb 2008 03:35:14 -0000 1.7
> +++ distinfo 15 Nov 2008 08:23:40 -0000
> @@ -1,5 +1,5 @@
> -MD5 (MailTools-2.02.tar.gz) = gkvb5sQIRzmsLQBe67CbDg==
> -RMD160 (MailTools-2.02.tar.gz) = SbdcJ1cCXp92NdAqiClhOp2CpNM=
> -SHA1 (MailTools-2.02.tar.gz) = luXGr7POFJK77HHLzE8kdYEDdzM=
> -SHA256 (MailTools-2.02.tar.gz) = zDFQ25QA5rJpsgwUDe/s+OhNizBrqFQe1Kmi8V+JTJs=
> -SIZE (MailTools-2.02.tar.gz) = 52013
> +MD5 (MailTools-2.04.tar.gz) = 0h6k83XR5fPaawpOi6Hixg==
> +RMD160 (MailTools-2.04.tar.gz) = eo0Unj08j8nmUWZZBjfu1RFbLLI=
> +SHA1 (MailTools-2.04.tar.gz) = b8zQT52w9HjhnuwEe+O/Ch2Cl/U=
> +SHA256 (MailTools-2.04.tar.gz) = valzSyEjQ9jk7CdDqY4Tg/NU86K7im1tkxds8jPLIXE=
> +SIZE (MailTools-2.04.tar.gz) = 52292
>
>
