Hi,
i've now came across numerous CPAN modules that use old versions of
Module::Install.  This makes us hit bugs that are in many cases fixed
already, for example we can't set CONFIGURE_ARGS=--skipdeps to prevent
the annoying interactive prompt/endless loop in a few cases.

I hereby suggest adding CONFIGURE_STYLE=modinst that pulls in
Module::Install (like done with Module::Build), sets
CONFIGURE_ARGS=--skipdeps and forces regeneration of the Module::Install
stuff.  This way we could get rid of upstream distribution bugs and a
lot of head scratching.

Thoughts?

Kind regards,
Simon


Index: perl.port.mk
===================================================================
RCS file: /cvs/ports/infrastructure/mk/perl.port.mk,v
retrieving revision 1.15
diff -u -p -r1.15 perl.port.mk
--- perl.port.mk        29 Sep 2008 22:55:46 -0000      1.15
+++ perl.port.mk        18 Jun 2009 13:00:33 -0000
@@ -33,6 +33,11 @@ MODPERL_configure = \
                INSTALLMAN3DIR='${PREFIX}/man/man3p' \
                INSTALLBIN='$${PREFIX}/bin' \
                INSTALLSCRIPT='$${INSTALLBIN}' ${CONFIGURE_ARGS}
+
+.  if ${CONFIGURE_STYLE:L:Mmodinst}
+BUILD_DEPENDS +=       ::devel/p5-Module-Install
+CONFIGURE_ARGS +=      --skipdeps
+.  endif
 .endif
 
 MODPERL_pre-fake = \
@@ -54,6 +59,11 @@ do-regress:
 do-install:
        @cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} /usr/bin/perl \
                ${MODPERL_BUILD} destdir=${WRKINST} ${FAKE_TARGET}
+.  endif
+.elif ${CONFIGURE_STYLE:L:Mmodinst}
+.  if !target(pre-configure)
+pre-configure:
+       @rm -rf ${WRKSRC}/inc/Module/*Install*
 .  endif
 .endif
 

Reply via email to