On Fri, Jul 17, 2009 at 07:15:17PM +0200, Giovanni Bechis wrote:
> pkg/DESCR
> Exaile is a music manager and player for GTK+ written in Python.
> It incorporates automatic fetching of album art, handling of large
> libraries, lyrics fetching, artist/album information via Wikipedia,
> Last.fm submission support, and optional iPod support via a plugin.
>
> Comments ? Ok ?
>  Cheers
>   Giovanni

Comments, after a bit of tweaking :

- It badly segfaults upon startup to me :
INFO    : Loading Exaile 0.2.99.2...
INFO    : Loading settings
/usr/local/lib/exaile/xlgui/__init__.py:23: Warning: cannot register
existing type `GdkPixbuf'
  gtk.window_set_default_icon_from_file(xdg.get_data_path("images/icon.png"))
/usr/local/lib/exaile/xlgui/__init__.py:23: Warning: g_once_init_leave:
assertion `initialization_value != 0' failed
  gtk.window_set_default_icon_from_file(xdg.get_data_path("images/icon.png"))
/usr/local/lib/exaile/xlgui/__init__.py:23: Warning: g_object_new:
assertion `G_TYPE_IS_OBJECT (object_type)' failed
  gtk.window_set_default_icon_from_file(xdg.get_data_path("images/icon.png"))
Segmentation fault 

Looks it doesn't find images/icon.png in data_dir, although the files
are in /usr/local/share/exaile/data, which is passed upon commandline
in bin/exaile wrapper..
adding print data_dirs in xl/xdg.py doesn't show this path though.
Trying to fix it to append 'exaile/data' instead of just 'exaile'
doesn't seem to do the trick.

- instead of handrolling do-build & do-install, using
  CONFIGURE_STYLE=none to trick python module and setting ALL_TARGET =
compile looks better to me. It also installs xlgui/*.py{c,o} while here,
which were missing in plist.

- same as several python ports & for consistency, all *.py* should go into
  lib/python2.5/site-packages/exaile (${MODPY_SITEPKG}) instead of
lib/exaile.

I'll try to investigate all that further..

Landry

Reply via email to