Hi, On Wed, 28.10.2009 at 10:59:34 +0000, Stuart Henderson <[email protected]> wrote: > if you're submitting new/updated ports, please run -current and keep > it fairly up-to-date so that you can check things work with what's in > the rest of the tree.
I generally understand this argument, but there are some (local) problems with it: * I can't run a full -current system, at least not until OpenBSD will run w/o problems on a virtual machine (XEN or KVM, in my case) / not create gotchas that I can only collect flames with. * I usually create ports to complement what I have in a current -stable system, 4.6-stable in this case. * For ports like p5-common-sense, the difference to -current is most likely negligible, except if someone changes eg. the implementation of SHA256 checksums again (these changed from 4.5 to 4.6, as I discovered when I wanted to check out William's patch for nginx earlier today). I'm fully aware that this difference is much greater, and likely really significant with respect to packages that actually have dependencies and/or binary components, and I can't really imagine sending in a port for such w/o appropriate warning. I started to have a full -current ports tree in addition to my -stable ports tree, however, although I'm also aware that this has it's own brand of problems. So... should I stop trying to create and/or update ports? > > -DISTNAME= common-sense-0.04 > > +DISTNAME= common-sense-2.01 > > it doesn't hurt, but why the extra tab here? (if it's due to having > tab spacing set to something other than 8, it would be helpful to change > that; in general the tree uses 8-char tabs). I have 8-char tabs. I see that I've created the diff like this: $ diff -uwrN /tmp/p5-common-sense p5-common-sense > /tmp/p5-common-sense.diff IOW, the difference in spacing is not noticed in lines where only spacing was different, but looking at the two Makefiles again, I see that I've aligned everything, while Kevin aligned the licensing stuff differently from the rest. -- Kind regards, --Toni++
