On Sat, Dec 19, 2009 at 04:01:04AM +0500, Alexandr Shadchin wrote:
> Hi!
> 
> Add sndio for audio/bonk
> Tested on i386.
> 
> Comments ? OK ?
> 

works for me

ok, beside a small nit:

> ++
> ++  if ((par.bits == 16 && par.le != askpar.le) ||

it's not necessary to check whether ``par.bits == 16''
because below you already check if ``par.bits != 16''.

> ++      par.bits != askpar.bits ||
> ++      par.sig != askpar.sig ||
> ++      par.pchan != askpar.pchan ||
> ++      ((par.rate * 1000 < askpar.rate * 995) ||
> ++       (par.rate * 1000 > askpar.rate * 1005)))
> ++    throw error("Parameters not supported");
> ++

-- Alexandre

Reply via email to