Hi,
On Tue, Dec 22, 2009 at 04:45:50PM +0100, Jona Joachim wrote:
> >From pkg/DESCR:
>
> Tabbed is a simple generic tabbed fronted to Xembed aware applications,
> originally designed for surf but also usable with many other
> applications, i.e. uzbl, urxvt and xterm.
>
> To get started:
>
> TABBEDWID=`tabbed -d`
> surf -e ${TABBEDWID} &
> xterm -into ${TABBEDWID} &
While this is a nice tool, some things are still slightly wrong.
With tabbed(1) itself as well as with the port:
- It hard-codes terminus as its font, so it should run-depend on it.
- It hard-codes surf as the program started on Ctrl-Shift-Return. So it
should either run-depend on surf, or you should patch the action to
just launching an xterm (I'd prefer the latter, even if the intention
of the suckless people was to write this tool mainly for surf).
- The usage mentioned in the README contained in the distfile, the usage
message displayed by tabbed(1), and the usage in the manpage differ.
Furthermore, something like
$ tabbed http://www.openbsd.org
doesn't work. At least the manpage should be fixed (that's probably
something you want to send upstream). Also, the manpage should mention
that the tabbed(1) writes the window id to stdout. Adding an example
section with the example you mention would be a good idea (of course,
also for upstream).
- Providing a config.mk in files/ isn't good. All this could be
overridden from the port makefile (using MAKE_FLAGS). However, even
this isn't enough (see next point).
- CFLAGS and LDFLAGS aren't honoured, and the executable isn't stripped.
I think you should patch the Makefile to an absolute minimum and
use ${BSD_INSTALL_PROGRAM} and the other BSD_INSTALL_* variables
provided by the ports framework. This way you'll get a stripped
executable automagically unless DEBUG is set (e.g. DEBUG=-g). And
since the Makefile has to be patched, you can as well patch it
to use CFLAGS and LDFLAGS from the environment. And please get rid of
things like -Os in CFLAGS ;-)
Ciao,
Kili
ps: while the stuff from suckless.org is really neat, their Makefiles
almost always suck more.
