Hi Stuart,

Stuart Henderson wrote on Wed, Feb 24, 2010 at 01:03:43AM +0000:
> On 2010/02/24 00:41, Ingo Schwarze wrote:

>>  - Nearly all names of utilities conflict with our in-tree groff,
>>    so you need to call them by their full paths.  Pay attention
>>    to the order of directories in your $PATH.  The same applies
>>    to manual pages.  Do not install this on production machines.

> we often use a prefix in the filenames for these (e.g. m4 -> gm4).

Yeah, ggroff sounds great.  ;-)

> ... of course this is not an issue if groff moves out of base in
> favour of mandoc, and groff moves completely to ports.

For that reason, i'm not fixing this right now:
There is a large number of binaries, some calling each other,
so renaming all of them will be tedious, and perhaps it turns
out it's not even needed.

>>  - /usr/local/lib/charset.alias conflicts with libiconv.
>>    I bluntly @comment-ed it out of the PLIST.

> if groff requires this, you probably want at least a RUN_DEPENDS
> on iconv (I would be more worried about possible dependency loops if
> this is used to build certain other basic ports with, than I would
> with trying to make it lightweight).

Indeed, groff wants BUILD_DEPENDS and RUN_DEPENDS libiconv,
and libiconv needs BUILD_DEPENDS groff because the port
builds a couple of manual pages.

On the other hand, all six iconv manual pages can be built
with mandoc.  So, why do we need a dependency on groff at all?
Perhaps we can just use mandoc for the iconv manual, breaking
the dependency loop.

But that's still some way off and can be sorted out later...

>>  - During the fake-install phase, there are a few error messages
>>    i did not investigate, see the Makefile.

> There are various "The program `gs' cannot be found in the PATH"
> during configure,

Yes, that's because i switched off gs support explicitely.

> and this during build (not fake):
> 
> Using perl version of groffer.
> install: groffer.man: chown/chgrp: Operation not permitted
> *** Error code 71 (continuing)
> Build for all aborted
> `all' not remade because of errors.

I need to investigate that later.

>>  - Some stuff is installed to places where it doesn't belong.

> adding this (and of course re-generating PLIST) helps:
> 
> MAKE_FLAGS +=           docdir=${PREFIX}/share/doc/groff \
>                         exampledir=${PREFIX}/share/examples/groff

Thanks, fixed in my tree.

Yours,
  Ingo

Reply via email to