Hi Kirill,
On 2010/05/17 13:10, Kirill Bychkov wrote:
> Hi. Looks good for me. As I can see, you've used some old port as a base. So,
> before commit, please change my name to Kirill Bychkov (without "S.").
> I wonder, is it still actual information in platforms/openbsd/README? It was
> written 6 years ago.
The APC UPS I have here is on a server that I can't play around with too
much, so I can't test the shutdown procedure, but I don't remember any
change to the OS which would affect the shutdown sequence. So I think
this is still current information:
During the OpenBSD shutdown sequence, however, the second "one shot" call
to apcupsd will fail because after the shutdown sequence has started, the
serial port cannot be reopened.
I noticed one thing which needs changing; the README file refers
to /etc/rc.apcups, this needs changing for apcupsctl.
I think I would just patch the README in pre-configure with
perl -pi -e 's,/etc/rc.apcups,${PREFIX}/sbin/apcupsctl,' ${WRKSRC}/....
If you have time to send an updated tar with this change,
I think this can probably go in - if you don't have time at the
moment I'll try and pick it up in a couple of days.
> And an old question: should it be apcupsd or apc-upsd?
Now that we have ports/devel/quirks, I think apcupsd is ok. We can
add a quirk so that users of the old apc-upsd can have the new package
installed. We also need to mention the change in www/faq/current.html.
If you can send diffs for those too, it would be helpful.
