On Thu, Jul 15, 2010 at 4:27 PM, Christopher Zimmermann <[email protected]> wrote: > On 07/15/10 14:12, David Coppa wrote: >> On Thu, Jul 15, 2010 at 1:55 PM, Christopher Zimmermann >> <[email protected]> wrote: >>> Hi, >>> >>> this is a JSON library needed by the latest versions of the i3 window >>> manager. >>> It builds very cleanly without any patches. Only a few strcpy warnings. >>> >>> The only problem is that fetching from github.com is a bit >>> difficult. This is how I do it: >> >> github is not reliable: we usually mirror the tarball. > > ok. Then could someone do this for me and possibly commit the port to CVS? > Here's a new diff with the port moved to devel/libyajl:
Some comments.
>
> Index: ports/devel/libyajl//Makefile
If the pkgname is yajl, then this should go under devel/yajl.
> ===================================================================
> RCS file: ports/devel/libyajl//Makefile
> diff -N ports/devel/libyajl//Makefile
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ ports/devel/libyajl//Makefile 15 Jul 2010 14:25:40 -0000
> @@ -0,0 +1,42 @@
> +# $OpenBSD: Makefile,v 1.0 2010/07/15 15:00:00 madroach Exp $
> +
> +COMMENT= Yet Another JSON Library
COMMENT shouldn't be capitalized.
> +
> +V= 1.0.9
> +PKGNAME= yajl-${V}
> +
> +DISTNAME= lloyd-yajl-${V}
> +EXTRACT_SUFX= .tar.gz
> +GITHUB_TARBALL= http://github.com/lloyd/yajl/tarball/
> +
> +CATEGORIES= devel
> +
> +SHARED_LIBS= yajl 0.0
> +
> +HOMEPAGE= http://lloyd.github.com/yajl/
> +
> +MAINTAINER= Christopher Zimmermann <[email protected]>
> +
> +# BSD
> +PERMIT_PACKAGE_CDROM= Yes
> +PERMIT_PACKAGE_FTP= Yes
> +PERMIT_DISTFILES_CDROM= Yes
> +PERMIT_DISTFILES_FTP= Yes
> +
> +WANTLIB= c pthread
> +
> +SEPARATE_BUILD= simple
> +
> +MODULES= devel/cmake
> +
> +LIB_DEPENDS= sqlite3.>=8::databases/sqlite3 \
> +
> glib-2.0.>=1200,gmodule-2.0.>=1200,gthread-2.0.>=1200::devel/glib2
these WANTLIB and LIB_DEPENDS are bogus. Have you done cut'n'paste
from another port?
yajl only depends on the c library.
> +fetch:
> + ftp -o ${FULLDISTDIR}/${DISTNAME}${EXTRACT_SUFX} \
> + ${GITHUB_TARBALL}${V}
> +
> +post-extract:
> + mv ${WRKDIR}/lloyd-yajl-* ${WRKDIR}/${DISTNAME}
This is ugly: use WRKDIST instead.
I've attached a polished tarball to this mail.
Ciao,
David
yajl.tgz
Description: GNU Zip compressed data
