On Sat, Oct 16, 2010 at 02:36:14PM +0200, Landry Breuil wrote:
> On Sat, Oct 16, 2010 at 08:46:16AM -0300, Gonzalo L. R. wrote:
> > Thanks Landry for you response, I delete the OPTIONS and .if define
> > thing, and make a new packages, is ok for you now?
> 
> Something is still wrong wrt autotools usage:
> 
> configure: creating ./config.status
> config.status: creating Makefile
> config.status: creating man/Makefile
> config.status: creating src/Makefile
> config.status: creating config/Makefile
> config.status: creating config.h
> config.status: executing default-1 commands
> ===>  Building for apachetop-0.12.6
> cd . && /bin/sh
> /usr/ports/pobj/apachetop-0.12.6/apachetop-0.12.6/config/missing --run 
> aclocal 
> Provide an AUTOMAKE_VERSION environment variable, please
> cd . && /bin/sh 
> /usr/ports/pobj/apachetop-0.12.6/apachetop-0.12.6/config/missing --run 
> autoheader
> Provide an AUTOCONF_VERSION environment variable, please
> cd .  && CONFIG_FILES= CONFIG_HEADERS=config.h  /bin/sh ./config.status
> config.status: creating config.h
> config.status: config.h is unchanged
> config.status: executing default-1 commands
> 
> aclocal/autoheader should not be called again during build.
> 
> Oh, and the Note in DESCR to point to the access_log file for OpenBSD is
> ugly. It should be patched to default to the correct path instead so
> that the defaults are sane.

Here's a fixed version:
- added cvs ids to Makefile
- no need for the patch, use --with-logfile to point to our default
- better COMMENT
- use autoconf
- tidy DESCR

ok anyone ?

Landry

Attachment: apachetop-0.12.6.tar.gz
Description: application/tar-gz

Reply via email to