Hi,
after upgrading to 4.8-stable this weekend I wanted to run audio/vlorb
to rip some of my CDs today, but it refused to:
$ vlorb
[!!] no useable oggenc found in path
$ which oggenc
/usr/local/bin/oggenc
It's just a perl script so I took a look at it and found out that it
executes 'oggenc -v' to check whether it's "usable."
$ oggenc -v
oggenc: invalid option -- v
WARNING: Unknown option specified, ignoring->
ERROR: No input files specified. Use -h for help.
$ oggenc -V
oggenc from vorbis-tools 1.4.0
And thus I verified that the other checks are still working (they do),
created a patch for 4.8-stable and are happily ripping my CDs to .ogg
again. :-)
As patches are usually only accepted for -current here, I tried to
figure out the new style depends, REVISION and adopted the patch
accordingly.
Regards,
Oliver Klima
Index: ports/audio/vlorb/Makefile
diff -u ports/audio/vlorb/Makefile:1.1.1.1 ports/audio/vlorb/Makefile:1.3
--- ports/audio/vlorb/Makefile:1.1.1.1 Mon Nov 22 13:19:48 2010
+++ ports/audio/vlorb/Makefile Mon Nov 22 13:34:57 2010
@@ -2,6 +2,7 @@
COMMENT= audio CD to audio file encoder
DISTNAME= vlorb-1.2
+PKGNAME= ${DISTNAME}p0
CATEGORIES= audio
HOMEPAGE= http://jk.yazzy.org/projects/vlorb/
@@ -16,7 +17,7 @@
RUN_DEPENDS= :cdparanoia-*:audio/cdparanoia \
:flac-*:audio/flac \
- :vorbis-tools-*:audio/vorbis-tools \
+ :vorbis-tools->=1.4.0:audio/vorbis-tools \
:vorbisgain-*:audio/vorbisgain \
:p5-CDDB-*:audio/p5-cddb
Index: ports/audio/vlorb/patches/patch-vlorb
diff -u ports/audio/vlorb/patches/patch-vlorb:1.1.1.1
ports/audio/vlorb/patches/patch-vlorb:1.2
--- ports/audio/vlorb/patches/patch-vlorb:1.1.1.1 Mon Nov 22 13:19:48 2010
+++ ports/audio/vlorb/patches/patch-vlorb Mon Nov 22 13:33:20 2010
@@ -1,9 +1,18 @@
$OpenBSD: patch-vlorb,v 1.4 2003/08/03 01:07:40 naddy Exp $
---- vlorb.orig Mon Jul 28 00:20:32 2003
-+++ vlorb Mon Jul 28 00:20:41 2003
+--- vlorb.orig Thu Jul 24 16:16:17 2003
++++ vlorb Mon Nov 22 13:23:12 2010
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl
+#!/usr/bin/perl
#
# vlorb, an audio CD to audio file encoder.
# Copyright (c) 2002, Jochem Kossen <[email protected]>
+@@ -288,7 +288,7 @@ sub phase3() {
+ sub detect_apps() {
+ `cdparanoia -V 2>&1`;
+ $global{have_cdparanoia} = 1 if ($? == 0);
+- `oggenc -v 2>&1`;
++ `oggenc -V 2>&1`;
+ $global{have_oggenc} = 1 if ($? == 0);
+ `flac -v 2>&1`;
+ $global{have_flac} = 1 if ($? == 0);
Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/vlorb/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile 15 Nov 2010 00:22:49 -0000 1.7
+++ Makefile 22 Nov 2010 12:55:25 -0000
@@ -2,6 +2,7 @@
COMMENT= audio CD to audio file encoder
DISTNAME= vlorb-1.2
+REVISION= 0
CATEGORIES= audio
HOMEPAGE= http://jk.yazzy.org/projects/vlorb/
@@ -16,7 +17,7 @@
RUN_DEPENDS= audio/cdparanoia \
audio/flac \
- audio/vorbis-tools \
+ vorbis-tools->=1.4.0:audio/vorbis-tools \
audio/vorbisgain \
audio/p5-cddb
Index: patches/patch-vlorb
===================================================================
RCS file: /cvs/ports/audio/vlorb/patches/patch-vlorb,v
retrieving revision 1.4
diff -u -r1.4 patch-vlorb
--- patches/patch-vlorb 3 Aug 2003 01:07:40 -0000 1.4
+++ patches/patch-vlorb 22 Nov 2010 12:55:25 -0000
@@ -1,9 +1,18 @@
$OpenBSD: patch-vlorb,v 1.4 2003/08/03 01:07:40 naddy Exp $
---- vlorb.orig Mon Jul 28 00:20:32 2003
-+++ vlorb Mon Jul 28 00:20:41 2003
+--- vlorb.orig Thu Jul 24 16:16:17 2003
++++ vlorb Mon Nov 22 13:23:12 2010
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl
+#!/usr/bin/perl
#
# vlorb, an audio CD to audio file encoder.
# Copyright (c) 2002, Jochem Kossen <[email protected]>
+@@ -288,7 +288,7 @@ sub phase3() {
+ sub detect_apps() {
+ `cdparanoia -V 2>&1`;
+ $global{have_cdparanoia} = 1 if ($? == 0);
+- `oggenc -v 2>&1`;
++ `oggenc -V 2>&1`;
+ $global{have_oggenc} = 1 if ($? == 0);
+ `flac -v 2>&1`;
+ $global{have_flac} = 1 if ($? == 0);
