On Sat, Dec 11, 2010 at 03:55:55PM +0100, Landry Breuil wrote:
> On Sun, Dec 12, 2010 at 12:50:53AM +0500, Alexandr Shadchin wrote:
> > On Sat, Dec 11, 2010 at 02:42:53PM +0100, Landry Breuil wrote:
> > > On Sat, Dec 11, 2010 at 04:37:36PM +0500, Alexandr Shadchin wrote:
> > > > Hi!
> > > > 
> > > > This update package audacious to the latest release 2.4.0.
> > > > Tested on amd64.
> > > > 
> > > > Comments ? OK ? 
> > > 
> > > Diff unreadable with gratuitious tab changes...
> > > 
> > 
> > correct
> > 
> > > > Index: patches/patch-man_Makefile
> > > 
> > > CONFIGURE_STYLE is autoconf; i doubt patching makefiles will work.
> > > Makefile.in or Makefile.am...
> > > 
> > 
> > no Makefile.in or Makefile.am, only Makefile :)
> 
> oh, good then.
> > 
> > > > +share/icons/hicolor/48x48/apps/audacious.png
> > > > +share/icons/hicolor/scalable/apps/audacious.svg
> > > 
> > > icons in share/icons/hicolor -> add corresponding goos to PLIST.
> > > 
> > 
> > -SHARED_LIBS =      audclient       1.0
> > +SHARED_LIBS =      audclient       1.0     # 2.0
> 
> Did you check that api didn't change ?
> 

add 3 new functions. I forgot increase minor.

> > +           x11/hicolor-icon-theme
> 
> Not needed in run_depends

ok, remove

> 
> > +-LIBS += ${GLIB_LIBS} ${MOWGLI_LIBS}
> > ++LIBS += ${GLIB_LIBS} ${MOWGLI_LIBS} -lexecinfo
> 
> Isn't it what was done by CONFIGURE_ENV ?
> 

Yes, it does the same.
But CONFIGURE_ENV linked libexecinfo to all.

> Landry

-- 
Alexandr Shadchin

Reply via email to